-
-
Notifications
You must be signed in to change notification settings - Fork 109
feat: add custom predicate support for equivalency assertions using FuncEqualityComparer #4141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
25 changes: 25 additions & 0 deletions
25
TUnit.Assertions/Conditions/Helpers/FuncEqualityComparer.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,25 @@ | ||
| namespace TUnit.Assertions.Conditions.Helpers; | ||
|
|
||
| /// <summary> | ||
| /// An IEqualityComparer implementation that uses a custom Func for equality comparison. | ||
| /// This allows users to pass lambda predicates to assertion methods like Using(). | ||
| /// </summary> | ||
| /// <typeparam name="T">The type of objects to compare.</typeparam> | ||
| internal sealed class FuncEqualityComparer<T> : IEqualityComparer<T> | ||
| { | ||
| private readonly Func<T?, T?, bool> _equals; | ||
|
|
||
| public FuncEqualityComparer(Func<T?, T?, bool> equals) | ||
| { | ||
| _equals = equals ?? throw new ArgumentNullException(nameof(equals)); | ||
| } | ||
|
|
||
| public bool Equals(T? x, T? y) => _equals(x, y); | ||
|
|
||
| // Return a constant hash code to force linear search in collection equivalency. | ||
| // This is intentional because: | ||
| // 1. We cannot derive a meaningful hash function from an equality predicate | ||
| // 2. CollectionEquivalencyChecker already uses O(n²) linear search for custom comparers | ||
| // 3. This matches the expected behavior for all custom IEqualityComparer implementations | ||
| public int GetHashCode(T obj) => 0; | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The test coverage for the new predicate overloads is incomplete. While IsEquivalentTo and NotEquivalentTo assertions are well tested, there are no tests for the other two assertion types that received the same Using(Func) overload:
Consider adding test cases similar to these existing ones to verify that the predicate overload works correctly for IsEquatableOrEqualTo and ContainsKey assertions. This would ensure complete coverage of the new API surface.