Skip to content

Conversation

@thomhurst
Copy link
Owner

This PR contains the following updates:

Package Type Update Change
Microsoft.AspNetCore.Mvc.Testing (source) nuget major 8.0.010.0.1
Microsoft.AspNetCore.Mvc.Testing (source) nuget major 9.0.010.0.1

Release Notes

dotnet/dotnet (Microsoft.AspNetCore.Mvc.Testing)

v9.0.7: .NET 9.0.7

You can build .NET 9.0 from the repository by cloning the release tag v9.0.7 and following the build instructions in the main README.md.

Alternatively, you can build from the sources attached to this release directly.
More information on this process can be found in the dotnet/dotnet repository.

Attached are PGP signatures for the GitHub generated tarball and zipball. You can find the public key at https://dot.net/release-key-2023

v9.0.6: .NET 9.0.6

You can build .NET 9.0 from the repository by cloning the release tag v9.0.6 and following the build instructions in the main README.md.

Alternatively, you can build from the sources attached to this release directly.
More information on this process can be found in the dotnet/dotnet repository.

Attached are PGP signatures for the GitHub generated tarball and zipball. You can find the public key at https://dot.net/release-key-2023

v9.0.5: .NET 9.0.5

You can build .NET 9.0 from the repository by cloning the release tag v9.0.5 and following the build instructions in the main README.md.

Alternatively, you can build from the sources attached to this release directly.
More information on this process can be found in the dotnet/dotnet repository.

Attached are PGP signatures for the GitHub generated tarball and zipball. You can find the public key at https://dot.net/release-key-2023

v9.0.4: .NET 9.0.4

You can build .NET 9.0 from the repository by cloning the release tag v9.0.4 and following the build instructions in the main README.md.

Alternatively, you can build from the sources attached to this release directly.
More information on this process can be found in the dotnet/dotnet repository.

Attached are PGP signatures for the GitHub generated tarball and zipball. You can find the public key at https://dot.net/release-key-2023

v9.0.3: .NET 9.0.3

You can build .NET 9.0 from the repository by cloning the release tag v9.0.3 and following the build instructions in the main README.md.

Alternatively, you can build from the sources attached to this release directly.
More information on this process can be found in the dotnet/dotnet repository.

Attached are PGP signatures for the GitHub generated tarball and zipball. You can find the public key at https://dot.net/release-key-2023

v9.0.2: .NET 9.0.2

You can build .NET 9.0 from the repository by cloning the release tag v9.0.2 and following the build instructions in the main README.md.

Alternatively, you can build from the sources attached to this release directly.
More information on this process can be found in the dotnet/dotnet repository.

Attached are PGP signatures for the GitHub generated tarball and zipball. You can find the public key at https://dot.net/release-key-2023

v9.0.1: .NET 9.0.1

You can build .NET 9.0 from the repository by cloning the release tag v9.0.1 and following the build instructions in the main README.md.

Alternatively, you can build from the sources attached to this release directly.
More information on this process can be found in the dotnet/dotnet repository.

Attached are PGP signatures for the GitHub generated tarball and zipball. You can find the public key at https://dot.net/release-key-2023

v9.0.0: .NET 9.0.0

You can build .NET 9.0 from the repository by cloning the release tag v9.0.0 and following the build instructions in the main README.md.

Alternatively, you can build from the sources attached to this release directly.
More information on this process can be found in the dotnet/dotnet repository.

Attached are PGP signatures for the GitHub generated tarball and zipball. You can find the public key at https://dot.net/release-key-2023

v8.0.18: .NET 8.0.18

You can build .NET 8.0 from the repository by cloning the release tag v8.0.18 and following the build instructions in the main README.md.

Alternatively, you can build from the sources attached to this release directly.
More information on this process can be found in the dotnet/dotnet repository.

Attached are PGP signatures for the GitHub generated tarball and zipball. You can find the public key at https://dot.net/release-key-2023

v8.0.17: .NET 8.0.17

You can build .NET 8.0 from the repository by cloning the release tag v8.0.17 and following the build instructions in the main README.md.

Alternatively, you can build from the sources attached to this release directly.
More information on this process can be found in the dotnet/dotnet repository.

Attached are PGP signatures for the GitHub generated tarball and zipball. You can find the public key at https://dot.net/release-key-2023

v8.0.16: .NET 8.0.16

You can build .NET 8.0 from the repository by cloning the release tag v8.0.16 and following the build instructions in the main README.md.

Alternatively, you can build from the sources attached to this release directly.
More information on this process can be found in the dotnet/dotnet repository.

Attached are PGP signatures for the GitHub generated tarball and zipball. You can find the public key at https://dot.net/release-key-2023

v8.0.15: .NET 8.0.15

You can build .NET 8.0 from the repository by cloning the release tag v8.0.15 and following the build instructions in the main README.md.

Alternatively, you can build from the sources attached to this release directly.
More information on this process can be found in the dotnet/dotnet repository.

Attached are PGP signatures for the GitHub generated tarball and zipball. You can find the public key at https://dot.net/release-key-2023

v8.0.14: .NET 8.0.14

You can build .NET 8.0 from the repository by cloning the release tag v8.0.14 and following the build instructions in the main README.md.

Alternatively, you can build from the sources attached to this release directly.
More information on this process can be found in the dotnet/dotnet repository.

Attached are PGP signatures for the GitHub generated tarball and zipball. You can find the public key at https://dot.net/release-key-2023

v8.0.13: .NET 8.0.13

You can build .NET 8.0 from the repository by cloning the release tag v8.0.13 and following the build instructions in the main README.md.

Alternatively, you can build from the sources attached to this release directly.
More information on this process can be found in the dotnet/dotnet repository.

Attached are PGP signatures for the GitHub generated tarball and zipball. You can find the public key at https://dot.net/release-key-2023

v8.0.12: .NET 8.0.12

You can build .NET 8.0 from the repository by cloning the release tag v8.0.12 and following the build instructions in the main README.md.

Alternatively, you can build from the sources attached to this release directly.
More information on this process can be found in the dotnet/dotnet repository.

Attached are PGP signatures for the GitHub generated tarball and zipball. You can find the public key at https://dot.net/release-key-2023

v8.0.11: .NET 8.0.11

You can build .NET 8.0 from the repository by cloning the release tag v8.0.11 and following the build instructions in the main README.md.

Alternatively, you can build from the sources attached to this release directly.
More information on this process can be found in the dotnet/dotnet repository.

Attached are PGP signatures for the GitHub generated tarball and zipball. You can find the public key at https://dot.net/release-key-2023

v8.0.10: .NET 8.0.10

You can build .NET 8.0 from the repository by cloning the release tag v8.0.10 and following the build instructions in the main README.md.

Alternatively, you can build from the sources attached to this release directly.
More information on this process can be found in the dotnet/dotnet repository.

Attached are PGP signatures for the GitHub generated tarball and zipball. You can find the public key at https://dot.net/release-key-2023

v8.0.8: .NET 8.0.8

You can build .NET 8.0 from the repository by cloning the release tag v8.0.8 and following the build instructions in the main README.md.

Alternatively, you can build from the sources attached to this release directly.
More information on this process can be found in the dotnet/dotnet repository.

Attached are PGP signatures for the GitHub generated tarball and zipball. You can find the public key at https://dot.net/release-key-2023

v8.0.7: .NET 8.0.7

You can build .NET 8.0 from the repository by cloning the release tag v8.0.7 and following the build instructions in the main README.md.

Alternatively, you can build from the sources attached to this release directly.
More information on this process can be found in the dotnet/dotnet repository.

Attached are PGP signatures for the GitHub generated tarball and zipball. You can find the public key at https://dot.net/release-key-2023

v8.0.6: .NET 8.0.6

You can build .NET 8.0 from the repository by cloning the release tag v8.0.6 and following the build instructions in the main README.md.

Alternatively, you can build from the sources attached to this release directly.
More information on this process can be found in the dotnet/dotnet repository.

Attached are PGP signatures for the GitHub generated tarball and zipball. You can find the public key at https://dot.net/release-key-2023

v8.0.5: .NET 8.0.5

You can build .NET 8 from the repository by cloning the release tag v8.0.5 and following the build instructions in the main README.md.

Alternatively, you can build from the sources attached to this release directly.
More information on this process can be found in the dotnet/dotnet repository.

Attached are PGP signatures for the GitHub generated tarball and zipball. You can find the public key at https://dot.net/release-key-2023

v8.0.4: .NET 8.0.4

You can build .NET 8.0 from the repository by cloning the release tag v8.0.4 and following the build instructions in the main README.md.

Alternatively, you can build from the sources attached to this release directly.
More information on this process can be found in the dotnet/dotnet repository.

Attached are PGP signatures for the GitHub generated tarball and zipball. You can find the public key at https://dot.net/release-key-2023

v8.0.3: .NET 8.0.3

You can build .NET 8.0 from the repository by cloning the release tag v8.0.3 and following the build instructions in the main README.md.

Alternatively, you can build from the sources attached to this release directly.
More information on this process can be found in the dotnet/dotnet repository.

Attached are PGP signatures for the GitHub generated tarball and zipball. You can find the public key at https://dot.net/release-key-2023

v8.0.2: .NET 8.0.2

You can build .NET 8.0 from the repository by cloning the release tag v8.0.2 and following the build instructions in the main README.md.

Alternatively, you can build from the sources attached to this release directly.
More information on this process can be found in the dotnet/dotnet repository.

Attached are PGP signatures for the GitHub generated tarball and zipball. You can find the public key at https://dot.net/release-key-2023

v8.0.1: .NET 8.0.1

You can build .NET 8.0 from the repository by cloning the release tag v8.0.1 and following the build instructions in the main README.md.

Alternatively, you can build from the sources attached to this release directly.
More information on this process can be found in the dotnet/dotnet repository.

Attached are PGP signatures for the GitHub generated tarball and zipball. You can find the public key at https://dotnet.microsoft.com/download/dotnet/release-key-2023.asc


Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Enabled.

Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about these updates again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot.

Copilot AI review requested due to automatic review settings December 21, 2025 05:09
@thomhurst thomhurst added dependencies Pull requests that update a dependency file MAJOR renovate-bot labels Dec 21, 2025
@thomhurst thomhurst enabled auto-merge (squash) December 21, 2025 05:09
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR attempts to update the Microsoft.AspNetCore.Mvc.Testing dependency from framework-specific versions (8.0.0 for net8.0 and 9.0.0 for net9.0) to version 10.0.1 across both target frameworks. However, this update introduces a critical configuration error where the Version and VersionOverride attributes conflict, and attempts to use a .NET 10.0-specific package version with .NET 8.0 and 9.0 target frameworks.

Key Issues

  • Version/VersionOverride Mismatch: The Version attribute is set to "10.0.1" while VersionOverride remains at the old framework-specific versions ("8.0.0" and "9.0.0"), creating inconsistent behavior depending on whether Central Package Management is enabled
  • Framework Compatibility: Microsoft.AspNetCore.Mvc.Testing 10.0.1 is designed for .NET 10.0, not for .NET 8.0 or 9.0

Comment on lines +16 to +20
<PackageReference Include="Microsoft.AspNetCore.Mvc.Testing" Version="10.0.1" VersionOverride="8.0.0" />
</ItemGroup>

<ItemGroup Condition="'$(TargetFramework)' == 'net9.0'">
<PackageReference Include="Microsoft.AspNetCore.Mvc.Testing" Version="9.0.0" VersionOverride="9.0.0" />
<PackageReference Include="Microsoft.AspNetCore.Mvc.Testing" Version="10.0.1" VersionOverride="9.0.0" />
Copy link

Copilot AI Dec 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Version attribute has been updated to 10.0.1, but the VersionOverride attribute still specifies the older framework-specific versions (8.0.0 and 9.0.0). This creates a conflict:

  • Line 16: Version="10.0.1" but VersionOverride="8.0.0"
  • Line 20: Version="10.0.1" but VersionOverride="9.0.0"

When Central Package Management (CPM) is enabled, VersionOverride takes precedence and will use the older versions (8.0.0 and 9.0.0), ignoring the Version attribute. When CPM is not enabled, it will attempt to use 10.0.1, which may not be compatible with net8.0 and net9.0 target frameworks.

Additionally, Microsoft.AspNetCore.Mvc.Testing version 10.0.1 is designed for .NET 10.0, not .NET 8.0 or 9.0. ASP.NET Core packages are typically framework-specific - version 8.x is for .NET 8.0, version 9.x is for .NET 9.0, and version 10.x is for .NET 10.0.

The correct approach would be to keep the Version attribute matching the VersionOverride for each target framework, ensuring consistent behavior regardless of CPM usage and maintaining proper framework compatibility.

Copilot uses AI. Check for mistakes.
@claude
Copy link
Contributor

claude bot commented Dec 21, 2025

Code Review - PR #4128

❌ Issue Identified: Incorrect Package Version Configuration

This PR contains a configuration error that will cause confusion and potentially unexpected behavior.

Problem

The changes update the Version attribute to 10.0.1 for both net8.0 and net9.0 targets, but keep the VersionOverride at the framework-specific versions:

<!-- For net8.0 -->
<PackageReference Include="Microsoft.AspNetCore.Mvc.Testing" Version="10.0.1" VersionOverride="8.0.0" />

<!-- For net9.0 -->
<PackageReference Include="Microsoft.AspNetCore.Mvc.Testing" Version="10.0.1" VersionOverride="9.0.0" />

Why This is Wrong

  1. VersionOverride takes precedence over Version in NuGet Central Package Management (CPM)
  2. The actual version used will still be 8.0.0 for net8.0 and 9.0.0 for net9.0
  3. The Version="10.0.1" attribute is misleading - it suggests version 10.0.1 will be used when it won't be
  4. Microsoft.AspNetCore.Mvc.Testing 10.x doesn't exist for .NET 8 or .NET 9 - it's only for .NET 10

Correct Approach

The Version attribute should match the VersionOverride value for clarity, or be removed entirely:

<!-- Option 1: Keep Version matching VersionOverride (clearer) -->
<ItemGroup Condition="'TARGETFRAMEWORK' == 'net8.0'">
  <PackageReference Include="Microsoft.AspNetCore.Mvc.Testing" Version="8.0.0" VersionOverride="8.0.0" />
</ItemGroup>

<ItemGroup Condition="'TARGETFRAMEWORK' == 'net9.0'">
  <PackageReference Include="Microsoft.AspNetCore.Mvc.Testing" Version="9.0.0" VersionOverride="9.0.0" />
</ItemGroup>

<!-- Option 2: Remove Version attribute entirely -->
<ItemGroup Condition="'TARGETFRAMEWORK' == 'net8.0'">
  <PackageReference Include="Microsoft.AspNetCore.Mvc.Testing" VersionOverride="8.0.0" />
</ItemGroup>

Root Cause

This appears to be a Renovate bot error. Renovate correctly updated Directory.Packages.props line 19 to version 10.0.1, but incorrectly tried to update the framework-specific Version attributes without understanding that:

  • These targets need framework-specific versions (8.x for net8.0, 9.x for net9.0)
  • The VersionOverride is intentionally set to override the CPM version

Recommendation

Do not merge this PR as-is.

Suggested fix:

  1. Revert the Version attribute changes in TUnit.AspNetCore/TUnit.AspNetCore.csproj
  2. Keep Version="8.0.0" for net8.0 target
  3. Keep Version="9.0.0" for net9.0 target
  4. The Directory.Packages.props update to 10.0.1 is fine (it applies to the net10.0 target)

Alternatively, configure Renovate to ignore the Version attributes in this file since they must remain framework-specific.

Additional Notes

  • No security concerns
  • No performance impact (if fixed correctly)
  • No test coverage needed (this is a configuration change)
  • Per TUnit's CLAUDE.md guidelines, this follows the "Modern C#" and "Reliability" principles by ensuring correct package references

Review generated by Claude Code

@thomhurst thomhurst merged commit e5f5be4 into main Dec 21, 2025
19 checks passed
@thomhurst thomhurst deleted the renovate/major-microsoft.aspnetcore branch December 21, 2025 06:11
This was referenced Dec 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file MAJOR renovate-bot

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants