Skip to content

Conversation

@thomhurst
Copy link
Owner

This PR contains the following updates:

Package Type Update Change
OpenTelemetry.Exporter.OpenTelemetryProtocol (source) nuget minor 1.13.1 -> 1.14.0
OpenTelemetry.Extensions.Hosting (source) nuget minor 1.13.1 -> 1.14.0

Release Notes

open-telemetry/opentelemetry-dotnet (OpenTelemetry.Exporter.OpenTelemetryProtocol)

v1.14.0

Release details: 1.14.0

  • Add support for .NET 10.0.
  • Breaking Change When targeting net8.0, the package now depends on version
    8.0.0 of the Microsoft.Extensions.DependencyInjection.Abstractions,
    Microsoft.Extensions.Diagnostics.Abstractions,
    Microsoft.Extensions.Hosting.Abstractions and
    Microsoft.Extensions.Logging.Configuration NuGet packages.
  • Update System.Diagnostics.DiagnosticSource dependency to 10.0.0
    for all target frameworks.
  • Update Microsoft.Extensions.* dependencies to 10.0.0
    for .NET Framework and .NET Standard.
  • Breaking Change NuGet packages now use the Sigstore bundle format
    (.sigstore.json) for digital signatures instead of separate signature
    (.sig) and certificate (.pem) files. This requires cosign 3.0 or later
    for verification. See the Digital signing
    section
    for updated verification instructions.

Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Enabled.

Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about these updates again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot.

@thomhurst thomhurst added dependencies Pull requests that update a dependency file MINOR renovate-bot labels Nov 12, 2025
@thomhurst thomhurst enabled auto-merge (squash) November 12, 2025 18:11
@claude
Copy link
Contributor

claude bot commented Nov 12, 2025

Claude finished @thomhurst's task —— View job


PR Review: OpenTelemetry Update to 1.14.0

Todo List

  • Read repository guidelines (CLAUDE.md)
  • Examine the changed project file
  • Analyze OpenTelemetry 1.14.0 release notes for breaking changes
  • Check for potential impact on TUnit functionality
  • Review test coverage implications
  • Provide comprehensive feedback

Review Summary

This PR updates OpenTelemetry packages from 1.13.1 to 1.14.0 in the TUnit Aspire starter template. The changes are minimal and well-scoped.

Code Quality & Best Practices ✅

  • Clean dependency update: Only updates the necessary packages
  • Consistent versioning: Both OpenTelemetry packages are updated to the same version (1.14.0)
  • Template-only impact: Changes are isolated to the TUnit.Aspire.Starter template, not core TUnit functionality

Potential Issues & Security Concerns ⚠️

  • Mixed OpenTelemetry versions: The project now has a version mismatch:

    • OpenTelemetry.Exporter.OpenTelemetryProtocol: 1.14.0
    • OpenTelemetry.Extensions.Hosting: 1.14.0
    • OpenTelemetry.Instrumentation.AspNetCore: 1.13.0 ⚠️
    • OpenTelemetry.Instrumentation.Http: 1.13.0 ⚠️
    • OpenTelemetry.Instrumentation.Runtime: 1.13.0 ⚠️
  • Breaking changes in 1.14.0:

    • For .NET 8.0 targets: Updated Microsoft.Extensions.* dependencies to 8.0.0 (this template targets net10.0, so not affected)
    • Digital signing format changed to Sigstore bundle format (packaging/distribution concern, not runtime)

Performance Considerations ✅

  • No performance impact expected from this update
  • OpenTelemetry 1.14.0 may include performance improvements from the maintainers

Test Coverage 📋

  • Current state: Limited test coverage for OpenTelemetry integration in templates
  • Recommendation: The TUnit.Templates.Tests project has snapshot tests that should verify the template generation works correctly
  • Missing: No runtime integration tests for OpenTelemetry functionality in the template

Recommendations

  1. Version Alignment 🔧: Consider updating the remaining OpenTelemetry packages to 1.14.0 for consistency:

    <PackageReference Include="OpenTelemetry.Instrumentation.AspNetCore" Version="1.14.0" />
    <PackageReference Include="OpenTelemetry.Instrumentation.Http" Version="1.14.0" />
    <PackageReference Include="OpenTelemetry.Instrumentation.Runtime" Version="1.14.0" />
  2. Test Template Generation ✅: Run the template tests to ensure the update doesn't break template instantiation:

    dotnet test TUnit.Templates.Tests
  3. Verify Compatibility 📋: Although not critical for a template, consider testing that the generated template works with the new OpenTelemetry version.

Overall Assessment: ✅ APPROVED

This is a straightforward dependency update with minimal risk. The changes are:

  • Safe: Only affects template generation, not core TUnit functionality
  • Non-breaking: No API changes in the template code
  • Well-scoped: Limited to OpenTelemetry dependencies

The only minor concern is the version inconsistency between OpenTelemetry packages, but this doesn't pose a significant risk.


@claude
Copy link
Contributor

claude bot commented Nov 12, 2025

Claude finished @thomhurst's task —— View job


PR Review: OpenTelemetry Update to 1.14.0

Todo List

  • Read repository guidelines (CLAUDE.md)
  • Examine the changed project file
  • Analyze OpenTelemetry 1.14.0 release notes for breaking changes
  • Check for potential impact on TUnit functionality
  • Review test coverage implications
  • Provide comprehensive feedback

Review Summary

This PR updates OpenTelemetry packages from 1.13.1 to 1.14.0 in the TUnit Aspire starter template. The changes are minimal and well-scoped.

Code Quality & Best Practices ✅

  • Clean dependency update: Only updates the necessary packages
  • Consistent versioning: Both OpenTelemetry packages are updated to the same version (1.14.0)
  • Template-only impact: Changes are isolated to the TUnit.Aspire.Starter template, not core TUnit functionality

Potential Issues & Security Concerns ⚠️

  • Mixed OpenTelemetry versions: The project now has a version mismatch:

    • OpenTelemetry.Exporter.OpenTelemetryProtocol: 1.14.0
    • OpenTelemetry.Extensions.Hosting: 1.14.0
    • OpenTelemetry.Instrumentation.AspNetCore: 1.13.0 ⚠️
    • OpenTelemetry.Instrumentation.Http: 1.13.0 ⚠️
    • OpenTelemetry.Instrumentation.Runtime: 1.13.0 ⚠️
  • Breaking changes in 1.14.0:

    • For .NET 8.0 targets: Updated Microsoft.Extensions.* dependencies to 8.0.0 (this template targets net10.0, so not affected)
    • Digital signing format changed to Sigstore bundle format (packaging/distribution concern, not runtime)

Performance Considerations ✅

  • No performance impact expected from this update
  • OpenTelemetry 1.14.0 may include performance improvements from the maintainers

Test Coverage 📋

  • Current state: Limited test coverage for OpenTelemetry integration in templates
  • Recommendation: The TUnit.Templates.Tests project has snapshot tests that should verify the template generation works correctly
  • Missing: No runtime integration tests for OpenTelemetry functionality in the template

Recommendations

  1. Version Alignment 🔧: Consider updating the remaining OpenTelemetry packages to 1.14.0 for consistency:

    <PackageReference Include="OpenTelemetry.Instrumentation.AspNetCore" Version="1.14.0" />
    <PackageReference Include="OpenTelemetry.Instrumentation.Http" Version="1.14.0" />
    <PackageReference Include="OpenTelemetry.Instrumentation.Runtime" Version="1.14.0" />
  2. Test Template Generation ✅: Run the template tests to ensure the update doesn't break template instantiation:

    dotnet test TUnit.Templates.Tests
  3. Verify Compatibility 📋: Although not critical for a template, consider testing that the generated template works with the new OpenTelemetry version.

Overall Assessment: ✅ APPROVED

This is a straightforward dependency update with minimal risk. The changes are:

  • Safe: Only affects template generation, not core TUnit functionality
  • Non-breaking: No API changes in the template code
  • Well-scoped: Limited to OpenTelemetry dependencies

The only minor concern is the version inconsistency between OpenTelemetry packages, but this doesn't pose a significant risk.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file MINOR renovate-bot

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants