-
-
Notifications
You must be signed in to change notification settings - Fork 96
fix: enhance filename generation to include all containing types #3686
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Claude finished @thomhurst's task —— View job PR Review: Fix filename generation to include all containing typesI've completed a comprehensive review of this PR. This is a well-implemented bug fix that addresses filename collision issues for nested test classes. ✅ SummaryProblem: The filename generator only included the innermost class name, causing collisions when multiple nested classes had the same name (e.g., Solution: Enhanced filename generation to include the full type hierarchy from outer-to-inner classes. 📋 Detailed AnalysisCode Quality ✅ Excellent
Algorithm Correctness ✅ Robust
Performance ✅ Efficient
Security & Robustness ✅ Safe
Test Coverage ✅ AdequateThe test files perfectly demonstrate the issue: // Before: Both would generate "Constructor.g.cs" (collision!)
Class1Tests.Constructor -> Constructor.g.cs
Class2Tests.Constructor -> Constructor.g.cs
// After: Unique filenames
Class1Tests.Constructor -> TUnit_TestProject_Bugs__3684_Class1Tests_Constructor.g.cs
Class2Tests.Constructor -> TUnit_TestProject_Bugs__3684_Class2Tests_Constructor.g.csCompliance with TUnit Guidelines ✅ Perfect
🚀 Strengths
🔍 Minor Observations
✅ RecommendationAPPROVE - This is a high-quality bug fix that:
The implementation is production-ready and should be merged. |
No description provided.