Skip to content

Worker pattern for maximum-parallel-limit #2910

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 14, 2025
Merged

Worker pattern for maximum-parallel-limit #2910

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
2ced42d
Clean up whitespace and remove unnecessary comments in TestMetadataGe…
thomhurst Aug 14, 2025
084d122
Fix deadlock when using --maximum-parallel-tests flag
thomhurst Aug 14, 2025
abe08ee
Add TestContext initialization in InvokeTypedTest for consistency
thomhurst Aug 14, 2025
c836d1b
Refactor TestContext usage in test invokers to conditionally declare …
thomhurst Aug 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion TUnit.Core.SourceGenerator.Tests/AbstractTests.Concrete1.verified.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,6 @@ internal sealed class ConcreteClass1_AssertClassName_TestSource_GUID : global::T
TestInvoker = async (instance, args) =>
{
var typedInstance = (global::TUnit.TestProject.AbstractTests.ConcreteClass1)instance;
var context = global::TUnit.Core.TestContext.Current;
await typedInstance.AssertClassName();
},
InvokeTypedTest = async (instance, args, cancellationToken) =>
Expand Down
4 changes: 0 additions & 4 deletions TUnit.Core.SourceGenerator.Tests/AbstractTests.Concrete2.verified.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,6 @@ internal sealed class ConcreteClass2_SecondTest_TestSource_GUID : global::TUnit.
TestInvoker = async (instance, args) =>
{
var typedInstance = (global::TUnit.TestProject.AbstractTests.ConcreteClass2)instance;
var context = global::TUnit.Core.TestContext.Current;
typedInstance.SecondTest();
await global::System.Threading.Tasks.Task.CompletedTask;
},
Expand Down Expand Up @@ -171,7 +170,6 @@ internal sealed class ConcreteClass2_AssertClassName_TestSource_GUID : global::T
TestInvoker = async (instance, args) =>
{
var typedInstance = (global::TUnit.TestProject.AbstractTests.ConcreteClass2)instance;
var context = global::TUnit.Core.TestContext.Current;
await typedInstance.AssertClassName();
},
InvokeTypedTest = async (instance, args, cancellationToken) =>
Expand Down Expand Up @@ -269,7 +267,6 @@ internal sealed class ConcreteClass2_SecondTest_TestSource_GUID : global::TUnit.
TestInvoker = async (instance, args) =>
{
var typedInstance = (global::TUnit.TestProject.AbstractTests.ConcreteClass2)instance;
var context = global::TUnit.Core.TestContext.Current;
typedInstance.SecondTest();
await global::System.Threading.Tasks.Task.CompletedTask;
},
Expand Down Expand Up @@ -368,7 +365,6 @@ internal sealed class ConcreteClass1_AssertClassName_TestSource_GUID : global::T
TestInvoker = async (instance, args) =>
{
var typedInstance = (global::TUnit.TestProject.AbstractTests.ConcreteClass1)instance;
var context = global::TUnit.Core.TestContext.Current;
await typedInstance.AssertClassName();
},
InvokeTypedTest = async (instance, args, cancellationToken) =>
Expand Down
2 changes: 0 additions & 2 deletions TUnit.Core.SourceGenerator.Tests/AfterAllTests.Test.verified.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,6 @@ internal sealed class CleanupTests_Test1_TestSource_GUID : global::TUnit.Core.In
TestInvoker = async (instance, args) =>
{
var typedInstance = (global::TUnit.TestProject.AfterTests.CleanupTests)instance;
var context = global::TUnit.Core.TestContext.Current;
await typedInstance.Test1();
},
InvokeTypedTest = async (instance, args, cancellationToken) =>
Expand Down Expand Up @@ -165,7 +164,6 @@ internal sealed class CleanupTests_Test2_TestSource_GUID : global::TUnit.Core.In
TestInvoker = async (instance, args) =>
{
var typedInstance = (global::TUnit.TestProject.AfterTests.CleanupTests)instance;
var context = global::TUnit.Core.TestContext.Current;
await typedInstance.Test2();
},
InvokeTypedTest = async (instance, args, cancellationToken) =>
Expand Down
2 changes: 0 additions & 2 deletions TUnit.Core.SourceGenerator.Tests/AfterTests.Test.verified.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,6 @@ internal sealed class CleanupTests_Test1_TestSource_GUID : global::TUnit.Core.In
TestInvoker = async (instance, args) =>
{
var typedInstance = (global::TUnit.TestProject.AfterTests.CleanupTests)instance;
var context = global::TUnit.Core.TestContext.Current;
await typedInstance.Test1();
},
InvokeTypedTest = async (instance, args, cancellationToken) =>
Expand Down Expand Up @@ -165,7 +164,6 @@ internal sealed class CleanupTests_Test2_TestSource_GUID : global::TUnit.Core.In
TestInvoker = async (instance, args) =>
{
var typedInstance = (global::TUnit.TestProject.AfterTests.CleanupTests)instance;
var context = global::TUnit.Core.TestContext.Current;
await typedInstance.Test2();
},
InvokeTypedTest = async (instance, args, cancellationToken) =>
Expand Down
15 changes: 0 additions & 15 deletions TUnit.Core.SourceGenerator.Tests/ArgsAsArrayTests.Test.verified.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,8 +80,6 @@ internal sealed class ArgsAsArrayTests_Params_TestSource_GUID : global::TUnit.Co
TestInvoker = async (instance, args) =>
{
var typedInstance = (global::TUnit.TestProject.ArgsAsArrayTests)instance;
var context = global::TUnit.Core.TestContext.Current;
// Invoke with only the arguments that were provided
switch (args.Length)
{
case 0:
Expand Down Expand Up @@ -112,7 +110,6 @@ internal sealed class ArgsAsArrayTests_Params_TestSource_GUID : global::TUnit.Co
},
InvokeTypedTest = async (instance, args, cancellationToken) =>
{
// Invoke with only the arguments that were provided
switch (args.Length)
{
case 0:
Expand Down Expand Up @@ -241,8 +238,6 @@ internal sealed class ArgsAsArrayTests_NonParams_TestSource_GUID : global::TUnit
TestInvoker = async (instance, args) =>
{
var typedInstance = (global::TUnit.TestProject.ArgsAsArrayTests)instance;
var context = global::TUnit.Core.TestContext.Current;
// Invoke with only the arguments that were provided
switch (args.Length)
{
case 1:
Expand All @@ -255,7 +250,6 @@ internal sealed class ArgsAsArrayTests_NonParams_TestSource_GUID : global::TUnit
},
InvokeTypedTest = async (instance, args, cancellationToken) =>
{
// Invoke with only the arguments that were provided
switch (args.Length)
{
case 1:
Expand Down Expand Up @@ -366,8 +360,6 @@ internal sealed class ArgsAsArrayTests_ParamsEnumerable_TestSource_GUID : global
TestInvoker = async (instance, args) =>
{
var typedInstance = (global::TUnit.TestProject.ArgsAsArrayTests)instance;
var context = global::TUnit.Core.TestContext.Current;
// Invoke with only the arguments that were provided
switch (args.Length)
{
case 0:
Expand Down Expand Up @@ -398,7 +390,6 @@ internal sealed class ArgsAsArrayTests_ParamsEnumerable_TestSource_GUID : global
},
InvokeTypedTest = async (instance, args, cancellationToken) =>
{
// Invoke with only the arguments that were provided
switch (args.Length)
{
case 0:
Expand Down Expand Up @@ -527,8 +518,6 @@ internal sealed class ArgsAsArrayTests_Enumerable_TestSource_GUID : global::TUni
TestInvoker = async (instance, args) =>
{
var typedInstance = (global::TUnit.TestProject.ArgsAsArrayTests)instance;
var context = global::TUnit.Core.TestContext.Current;
// Invoke with only the arguments that were provided
switch (args.Length)
{
case 1:
Expand All @@ -541,7 +530,6 @@ internal sealed class ArgsAsArrayTests_Enumerable_TestSource_GUID : global::TUni
},
InvokeTypedTest = async (instance, args, cancellationToken) =>
{
// Invoke with only the arguments that were provided
switch (args.Length)
{
case 1:
Expand Down Expand Up @@ -659,8 +647,6 @@ internal sealed class ArgsAsArrayTests_Following_Non_Params_TestSource_GUID : gl
TestInvoker = async (instance, args) =>
{
var typedInstance = (global::TUnit.TestProject.ArgsAsArrayTests)instance;
var context = global::TUnit.Core.TestContext.Current;
// Invoke with only the arguments that were provided
switch (args.Length)
{
case 2:
Expand All @@ -673,7 +659,6 @@ internal sealed class ArgsAsArrayTests_Following_Non_Params_TestSource_GUID : gl
},
InvokeTypedTest = async (instance, args, cancellationToken) =>
{
// Invoke with only the arguments that were provided
switch (args.Length)
{
case 2:
Expand Down
6 changes: 0 additions & 6 deletions TUnit.Core.SourceGenerator.Tests/ArgumentWithImplicitConverterTests.Test.verified.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,8 +85,6 @@ internal sealed class ArgumentWithImplicitConverterTests_Explicit_TestSource_GUI
TestInvoker = async (instance, args) =>
{
var typedInstance = (global::TUnit.TestProject.ArgumentWithImplicitConverterTests)instance;
var context = global::TUnit.Core.TestContext.Current;
// Invoke with only the arguments that were provided
switch (args.Length)
{
case 1:
Expand All @@ -99,7 +97,6 @@ internal sealed class ArgumentWithImplicitConverterTests_Explicit_TestSource_GUI
},
InvokeTypedTest = async (instance, args, cancellationToken) =>
{
// Invoke with only the arguments that were provided
switch (args.Length)
{
case 1:
Expand Down Expand Up @@ -215,8 +212,6 @@ internal sealed class ArgumentWithImplicitConverterTests_Implicit_TestSource_GUI
TestInvoker = async (instance, args) =>
{
var typedInstance = (global::TUnit.TestProject.ArgumentWithImplicitConverterTests)instance;
var context = global::TUnit.Core.TestContext.Current;
// Invoke with only the arguments that were provided
switch (args.Length)
{
case 1:
Expand All @@ -229,7 +224,6 @@ internal sealed class ArgumentWithImplicitConverterTests_Implicit_TestSource_GUI
},
InvokeTypedTest = async (instance, args, cancellationToken) =>
{
// Invoke with only the arguments that were provided
switch (args.Length)
{
case 1:
Expand Down
3 changes: 0 additions & 3 deletions TUnit.Core.SourceGenerator.Tests/AssemblyLoaderTests.Test.DotNet8_0.verified.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,6 @@ internal sealed class BasicTests_SynchronousTest_TestSource_GUID : global::TUnit
TestInvoker = async (instance, args) =>
{
var typedInstance = (global::TUnit.TestProject.BasicTests)instance;
var context = global::TUnit.Core.TestContext.Current;
typedInstance.SynchronousTest();
await global::System.Threading.Tasks.Task.CompletedTask;
},
Expand Down Expand Up @@ -167,7 +166,6 @@ internal sealed class BasicTests_AsynchronousTest_TestSource_GUID : global::TUni
TestInvoker = async (instance, args) =>
{
var typedInstance = (global::TUnit.TestProject.BasicTests)instance;
var context = global::TUnit.Core.TestContext.Current;
await typedInstance.AsynchronousTest();
},
InvokeTypedTest = async (instance, args, cancellationToken) =>
Expand Down Expand Up @@ -263,7 +261,6 @@ internal sealed class BasicTests_ValueTaskAsynchronousTest_TestSource_GUID : glo
TestInvoker = async (instance, args) =>
{
var typedInstance = (global::TUnit.TestProject.BasicTests)instance;
var context = global::TUnit.Core.TestContext.Current;
await typedInstance.ValueTaskAsynchronousTest();
},
InvokeTypedTest = async (instance, args, cancellationToken) =>
Expand Down
3 changes: 0 additions & 3 deletions TUnit.Core.SourceGenerator.Tests/AssemblyLoaderTests.Test.DotNet9_0.verified.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,6 @@ internal sealed class BasicTests_SynchronousTest_TestSource_GUID : global::TUnit
TestInvoker = async (instance, args) =>
{
var typedInstance = (global::TUnit.TestProject.BasicTests)instance;
var context = global::TUnit.Core.TestContext.Current;
typedInstance.SynchronousTest();
await global::System.Threading.Tasks.Task.CompletedTask;
},
Expand Down Expand Up @@ -167,7 +166,6 @@ internal sealed class BasicTests_AsynchronousTest_TestSource_GUID : global::TUni
TestInvoker = async (instance, args) =>
{
var typedInstance = (global::TUnit.TestProject.BasicTests)instance;
var context = global::TUnit.Core.TestContext.Current;
await typedInstance.AsynchronousTest();
},
InvokeTypedTest = async (instance, args, cancellationToken) =>
Expand Down Expand Up @@ -263,7 +261,6 @@ internal sealed class BasicTests_ValueTaskAsynchronousTest_TestSource_GUID : glo
TestInvoker = async (instance, args) =>
{
var typedInstance = (global::TUnit.TestProject.BasicTests)instance;
var context = global::TUnit.Core.TestContext.Current;
await typedInstance.ValueTaskAsynchronousTest();
},
InvokeTypedTest = async (instance, args, cancellationToken) =>
Expand Down
3 changes: 0 additions & 3 deletions TUnit.Core.SourceGenerator.Tests/AssemblyLoaderTests.Test.Net4_7.verified.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,6 @@ internal sealed class BasicTests_SynchronousTest_TestSource_GUID : global::TUnit
TestInvoker = async (instance, args) =>
{
var typedInstance = (global::TUnit.TestProject.BasicTests)instance;
var context = global::TUnit.Core.TestContext.Current;
typedInstance.SynchronousTest();
await global::System.Threading.Tasks.Task.CompletedTask;
},
Expand Down Expand Up @@ -167,7 +166,6 @@ internal sealed class BasicTests_AsynchronousTest_TestSource_GUID : global::TUni
TestInvoker = async (instance, args) =>
{
var typedInstance = (global::TUnit.TestProject.BasicTests)instance;
var context = global::TUnit.Core.TestContext.Current;
await typedInstance.AsynchronousTest();
},
InvokeTypedTest = async (instance, args, cancellationToken) =>
Expand Down Expand Up @@ -263,7 +261,6 @@ internal sealed class BasicTests_ValueTaskAsynchronousTest_TestSource_GUID : glo
TestInvoker = async (instance, args) =>
{
var typedInstance = (global::TUnit.TestProject.BasicTests)instance;
var context = global::TUnit.Core.TestContext.Current;
await typedInstance.ValueTaskAsynchronousTest();
},
InvokeTypedTest = async (instance, args, cancellationToken) =>
Expand Down
Loading
Loading