-
-
Notifications
You must be signed in to change notification settings - Fork 94
Fix: Enable Polyfill package by default for netstandard2.0 in TUnit.Core #2745
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: thomhurst <[email protected]>
Copilot
AI
changed the title
[WIP] Make sure the TUnit.Core package pulls in the
Fix: Enable Polyfill package by default for netstandard2.0 in TUnit.Core
Aug 4, 2025
Polyfill package to consuming test projects if using the netstandard2.0 variant
Copilot finished work on behalf of
thomhurst
August 4, 2025 11:32
This was referenced Aug 6, 2025
Open
This was referenced Sep 22, 2025
This was referenced Sep 29, 2025
This was referenced Oct 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The TUnit.Core package was not automatically pulling in the Polyfill package for consuming test projects targeting netstandard2.0, requiring users to manually add the package or explicitly set
EnableTUnitPolyfills=true.Problem
When developers created test projects targeting netstandard2.0 and referenced TUnit.Core, they would encounter missing method exceptions or compilation errors because modern .NET APIs used by TUnit were not available in netstandard2.0 without the Polyfill package.
Solution
Modified the condition in
TUnit.Core.targetsfrom:To:
This change makes the Polyfill package included by default for netstandard2.0 targets while preserving the ability to opt out by setting
<EnableTUnitPolyfills>false</EnableTUnitPolyfills>in the project file.Testing
EnableTUnitPolyfillsis set tofalseFixes #2744.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.