-
-
Notifications
You must be signed in to change notification settings - Fork 95
Fix cancellation cleanup: ensure After hooks execute when test run is cancelled #2732
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…for cleanup hooks Co-authored-by: thomhurst <[email protected]>
Co-authored-by: thomhurst <[email protected]>
Copilot
AI
changed the title
[WIP] If a test run is cancelled, invoke all relevant clean up methods
Fix cancellation cleanup: ensure After hooks execute when test run is cancelled
Aug 4, 2025
Copilot finished work on behalf of
thomhurst
August 4, 2025 00:33
This was referenced Aug 6, 2025
Open
This was referenced Sep 23, 2025
This was referenced Oct 1, 2025
This was referenced Oct 8, 2025
This was referenced Oct 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a test run is cancelled (e.g., via Ctrl+C), cleanup hooks were not executing properly because they were using the same cancelled
CancellationTokenthat triggered the cancellation. This could lead to incomplete cleanup and resource leaks.Problem
The issue occurred in two key locations:
HookOrchestratingTestExecutorAdapter.ExecuteTestAsync()- thefinallyblock was calling cleanup hooks with the maincancellationTokenTestExecutor.ExecuteTests()- session cleanup was also using the cancelled tokenWhen cancellation occurred, these cleanup operations would receive an already-cancelled token, potentially preventing proper execution of
[After(Test)],[After(Class)],[After(Assembly)], and[After(TestSession)]hooks.Solution
Modified both cleanup paths to use separate
CancellationTokenSourceinstances with reasonable timeouts:This ensures cleanup hooks have independent cancellation tokens and sufficient time to complete their work, even when the main test execution is cancelled.
Code Changes
Benefits
Fixes #2731.
Warning
Firewall rules blocked me from connecting to one or more addresses
I tried to connect to the following addresses, but was blocked by firewall rules:
aka.mscurl -I -sSL --retry 5 --retry-delay 2 --connect-timeout 15 REDACTED(dns block)If you need me to access, download, or install something from one of these locations, you can either:
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.