Conversation
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This is a straightforward Renovate Bot dependency bump: TUnit 1.25.0 → 1.27.0 across both test projects, and TUnit.Logging.Microsoft 1.25.0 → 1.27.0 in the integration test project.
Changes
tests/Dekaf.Tests.Integration/Dekaf.Tests.Integration.csproj: TUnit + TUnit.Logging.Microsoft bumped to 1.27.0tests/Dekaf.Tests.Unit/Dekaf.Tests.Unit.csproj: TUnit bumped to 1.27.0
Assessment
No issues found. The update is clean and consistent across both test projects.
A few observations worth noting:
-
TUnit 1.27.0 release notes: The release includes removal of all
[Obsolete]members (#5384) and drops net6.0/net7.0 TFMs. Since Dekaf targets net10.0+, the TFM drop is irrelevant, but if any test code was using deprecated TUnit APIs, the build will now fail — which is a good forcing function to keep tests up to date. -
Version pinning consistency:
TUnitandTUnit.Logging.Microsoftare pinned to exact versions (1.27.0) while other dependencies likeTestcontainers.Kafka,Microsoft.Testing.Extensions.HangDump, andVerify.TUnituse wildcard*versions. This is intentional and fine for a test framework — exact pinning on TUnit ensures deterministic test behavior across environments, while wildcards on support tooling are less risk-sensitive. -
Automerge enabled: This PR has automerge on, which is appropriate for minor test dependency bumps like this.
Approved. Safe to merge once CI passes.
There was a problem hiding this comment.
Code Review
This is a straightforward Renovate Bot dependency bump: TUnit 1.25.0 → 1.27.0 across both test projects, and TUnit.Logging.Microsoft 1.25.0 → 1.27.0 in the integration test project.
Changes
tests/Dekaf.Tests.Integration/Dekaf.Tests.Integration.csproj: TUnit + TUnit.Logging.Microsoft bumped to 1.27.0tests/Dekaf.Tests.Unit/Dekaf.Tests.Unit.csproj: TUnit bumped to 1.27.0
Assessment
No issues found. The update is clean and consistent across both test projects.
A few observations:
-
TUnit 1.27.0 release notes: The release removes all
[Obsolete]members (thomhurst/TUnit#5384) and drops net6.0/net7.0 TFMs. Since Dekaf targets net10.0+, the TFM drop is irrelevant. If any test code was using deprecated TUnit APIs, the build will now surface that — a good forcing function to keep tests up to date. -
Version pinning consistency:
TUnitandTUnit.Logging.Microsoftare pinned to exact versions while other test dependencies use wildcard*versions. Exact pinning on the test framework is appropriate for deterministic test behavior across environments. -
Automerge enabled: Appropriate for minor test dependency bumps like this.
Safe to merge once CI passes.
thomhurst
changed the title
thomhurst
force-pushed
the
renovate/tunit
branch
from
a304f31 to
fc9c31f
Compare
There was a problem hiding this comment.
Code Review
This is a Renovate Bot dependency bump: TUnit 1.25.0 → 1.28.0 across both test projects, and TUnit.Logging.Microsoft 1.25.0 → 1.28.0 in the integration test project.
Changes
tests/Dekaf.Tests.Integration/Dekaf.Tests.Integration.csproj: TUnit + TUnit.Logging.Microsoft bumped to 1.28.0tests/Dekaf.Tests.Unit/Dekaf.Tests.Unit.csproj: TUnit bumped to 1.28.0
Update from Previous Review
The prior reviews referenced 1.27.0 — this PR has since been updated to 1.28.0. The additional changes in 1.28.0 over 1.27.0 are all performance improvements and bug fixes:
- 30-42% faster MockEngine hot paths (good alignment with Dekaf's performance focus)
- Deferred per-class JIT via lazy test registration + parallel resolution
- Typed
HandleCall<T1,...>overloads to eliminate argument boxing - Fix for mock class name generation with generic interfaces
None of these changes affect the test API surface or require any code changes on the Dekaf side.
Assessment
No issues found. The update is clean, consistent across both test projects, and the 1.28.0 improvements are strictly additive. Automerge is appropriate here.
Safe to merge once CI passes.
2 participants
This PR contains the following updates:
1.25.0→1.28.01.25.0→1.28.0Release Notes
thomhurst/TUnit (TUnit)
v1.28.0: 1.28.0What's Changed
Other Changes
Dependencies
Full Changelog: thomhurst/TUnit@v1.27.0...v1.28.0
v1.27.0: 1.27.0What's Changed
Other Changes
Dependencies
Full Changelog: thomhurst/TUnit@v1.25.0...v1.27.0
Configuration
📅 Schedule: (UTC)
🚦 Automerge: Enabled.
♻ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about these updates again.
This PR has been generated by Renovate Bot.