Unblock Dependabot PRs: Angular 22 + NgRx 22 + TS 6, audit fixes, CI hardening - #277
Conversation
…xes, CI hardening - Upgrade Angular 21.2 -> 22.1 together with NgRx 22 and TypeScript 6 via ng update (supersedes #226 and #258, which cannot resolve on their own). - Fix TS 6 config errors the migration leaves behind: drop deprecated baseUrl, set rootDir explicitly; pass CanMatchFn's new third argument in the guard spec. - Pick up playwright 1.63 and @types/node 24.13.4 (#275) and run npm audit fix; production and full-tree audits both report 0 vulnerabilities. - Promote the full-tree npm audit step to blocking now that Angular 22 has landed. - Deflake EventSeriesEndpointsTests: allow 30s instead of 5s for the shared Elasticsearch node to surface reindexed occurrences (failed on #276). - Dependabot: ignore majors of jasmine-core (7 makes describe read-only, which zone.js/testing reassigns) and Microsoft.OpenApi (3.x is incompatible with Microsoft.AspNetCore.OpenApi 10). Superseded: #255, #257. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
|
Warning Review the following alerts detected in dependencies. According to your organization's Security Policy, it is recommended to resolve "Warn" alerts. Learn more about Socket for GitHub.
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 41f76ad485
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| "@angular/build": "^22.1.8", | ||
| "@angular/cli": "^22.1.8", |
There was a problem hiding this comment.
Raise the advertised Node.js minimum for Angular 22
When installing with Node 24.0–24.14 or Node 25.x, this Angular upgrade conflicts with the project's existing engines.node declaration of >=24: the new Angular CLI and build packages require ^22.22.3 || ^24.15.0 || >=26.0.0 (for example, frontend/package-lock.json lines 547–549). Such environments are currently presented as supported but can be rejected by engine-strict installs or run an unsupported build toolchain, so update the project engine constraint and version pins to require a compatible Node release.
Useful? React with 👍 / 👎.
Why
Six Dependabot PRs were stuck on CI. Their failures came from four separate causes. Some can only be fixed on main, and some bumps can never merge on their own:
qsadvisories published against main; the prod audit gate fails for every PRnpm audit fix; bumps includedEventSeriesEndpointsTests(5s wait on the shared Elasticsearch node)@angular/build@22requires TypeScript>=6.0 <6.1ng updatetogether with TS 6@ngrx/*@22requires@angular/core ^22describeread-only; zone.js/testing reassigns it, so no spec loadsMicrosoft.AspNetCore.OpenApi10 is built against OpenApi 2.x (csproj already pins 2.x on purpose)What changed
withNoIncrementalHydration(),withXhr()in test HTTP providers,$safeNavigationMigration()template wrappers, extended-diagnostic suppressions,istanbul-lib-instrument.baseUrl(pathsnow./-relative), explicitrootDirin app/spec tsconfigs, and the thirdCanMatchFnargument in the guard spec.npm audit --audit-level=moderateis now blocking. Its comment said to do this once Angular 22 landed, and both audits now report 0 vulnerabilities.EventSeriesEndpointsTestspublic-listing wait goes from 5s to 30s.jasmine-coreandMicrosoft.OpenApi, and refresh the stale TypeScript ignore comment.Verified locally
npm run format:check,npm run typecheck,npm run build: pass. The initial-bundle budget warning was already on main (537 kB); it's now 547 kB.ng test --watch=false --code-coverage: pass, 91.7% statements.npm audit --omit=dev --audit-level=highandnpm audit --audit-level=moderate: 0 vulnerabilities.After merge
@dependabot rebaseon chore(deps): Bump the backend-dependencies group with 17 updates #276.🤖 Generated with Claude Code