fix(datacollector): Return early when client disconnects#4349
Merged
thomaspoignant merged 2 commits intothomaspoignant:mainfrom Nov 24, 2025
Conversation
Signed-off-by: Dave Henderson <dhenderson@gmail.com>
✅ Deploy Preview for go-feature-flag-doc-preview canceled.
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4349 +/- ##
==========================================
+ Coverage 85.07% 85.10% +0.03%
==========================================
Files 142 142
Lines 5895 5909 +14
==========================================
+ Hits 5015 5029 +14
Misses 663 663
Partials 217 217 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…s-at-context-cancellation-4346
|
thomaspoignant
approved these changes
Nov 24, 2025
Owner
thomaspoignant
left a comment
thomaspoignant
left a comment
There was a problem hiding this comment.
@hairyhenderson thanks again for your contribution this is really a nice addition that can help in high load. 🙇
hairyhenderson
deleted the
hairyhenderson/cancel-data-collector-requests-at-context-cancellation-4346
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #4346 by stopping work early when clients disconnect from
/v1/data/collector. While some of the memory use was due to the debug logger (fixed in #4348), much more memory is used when many requests are sent while not stopping execution (and freeing resources) once the client disconnects:Closes issue(s)
Fixes #4346
Checklist
README.mdand/website/docs)