Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(python): Fix URL formatting + authorized key #2707

Merged
merged 3 commits into from
Nov 23, 2024
Merged

Conversation

thomaspoignant
Copy link
Owner

Description

This PR fixes 2 things:

  • Allow to set authorized key in the option if you use an authenticated version of GO Feature Flag
  • Fix URL formatting when GOFF is not on the root level of the path.

Closes issue(s)

Resolve #2690 #2671

Checklist

  • I have tested this code
  • I have added unit test to cover this code
  • I have updated the documentation (README.md and /website/docs)
  • I have followed the contributing guide

Copy link

netlify bot commented Nov 22, 2024

Deploy Preview for go-feature-flag-doc-preview canceled.

Name Link
🔨 Latest commit 1242d4b
🔍 Latest deploy log https://app.netlify.com/sites/go-feature-flag-doc-preview/deploys/6740c91b5cc22a0008640626

Copy link

netlify bot commented Nov 22, 2024

Deploy Preview for go-feature-flag-doc-preview canceled.

Name Link
🔨 Latest commit ffaf084
🔍 Latest deploy log https://app.netlify.com/sites/go-feature-flag-doc-preview/deploys/6740c9211196940008c01375

Copy link

sonarcloud bot commented Nov 22, 2024

Copy link

codecov bot commented Nov 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.73%. Comparing base (0fcbe58) to head (ffaf084).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2707   +/-   ##
=======================================
  Coverage   84.73%   84.73%           
=======================================
  Files         111      111           
  Lines        5162     5162           
=======================================
  Hits         4374     4374           
  Misses        624      624           
  Partials      164      164           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@thomaspoignant thomaspoignant merged commit 924c691 into main Nov 23, 2024
22 checks passed
@thomaspoignant thomaspoignant deleted the fix-python branch November 23, 2024 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(bug) Python Url parse
1 participant