-
-
Notifications
You must be signed in to change notification settings - Fork 151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Azure Blob Storage Retriever #2672
Conversation
✅ Deploy Preview for go-feature-flag-doc-preview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Abeeujah thanks for your PR, I've made some comments and the PR needs some changes.
@Abeeujah Test are not passing can you look at it? |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2672 +/- ##
==========================================
- Coverage 84.91% 84.50% -0.42%
==========================================
Files 105 106 +1
Lines 4940 5021 +81
==========================================
+ Hits 4195 4243 +48
- Misses 588 616 +28
- Partials 157 162 +5 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
b83d446
to
c1b9b23
Compare
Hi @thomaspoignant my bad; I didn't update the tests after implementing the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀 LGTM
Signed-off-by: Thomas Poignant <[email protected]>
Quality Gate passedIssues Measures |
Description
Azure Blob Storage Retriever to get feature flag configurations directly from Azure.
Closes issue(s)
Resolve #2558
Checklist
README.md
and/website/docs
)