Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Azure Blob Storage Retriever #2672

Merged
merged 6 commits into from
Nov 21, 2024
Merged

Conversation

Abeeujah
Copy link
Contributor

@Abeeujah Abeeujah commented Nov 16, 2024

Description

Azure Blob Storage Retriever to get feature flag configurations directly from Azure.

Closes issue(s)

Resolve #2558

Checklist

  • I have tested this code
  • I have added unit test to cover this code
  • I have updated the documentation (README.md and /website/docs)
  • I have followed the contributing guide

Copy link

netlify bot commented Nov 16, 2024

Deploy Preview for go-feature-flag-doc-preview ready!

Name Link
🔨 Latest commit 8d55d1b
🔍 Latest deploy log https://app.netlify.com/sites/go-feature-flag-doc-preview/deploys/673f63793bf9080008b35114
😎 Deploy Preview https://deploy-preview-2672--go-feature-flag-doc-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Owner

@thomaspoignant thomaspoignant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Abeeujah thanks for your PR, I've made some comments and the PR needs some changes.

README.md Outdated Show resolved Hide resolved
cmd/relayproxy/config/retriever.go Outdated Show resolved Hide resolved
retriever/azblobstorageretriever/retriever.go Outdated Show resolved Hide resolved
cmd/relayproxy/config/retriever_test.go Show resolved Hide resolved
cmd/relayproxy/config/retriever_test.go Show resolved Hide resolved
cmd/relayproxy/service/gofeatureflag.go Outdated Show resolved Hide resolved
retriever/azblobstorageretriever/README.md Outdated Show resolved Hide resolved
retriever/azblobstorageretriever/retriever.go Outdated Show resolved Hide resolved
retriever/azblobstorageretriever/retriever.go Outdated Show resolved Hide resolved
@thomaspoignant
Copy link
Owner

@Abeeujah Test are not passing can you look at it?

Copy link

codecov bot commented Nov 19, 2024

Codecov Report

Attention: Patch coverage is 59.75610% with 33 lines in your changes missing coverage. Please review.

Project coverage is 84.50%. Comparing base (41cccf7) to head (8d55d1b).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
retriever/azblobstorageretriever/retriever.go 58.33% 20 Missing and 5 partials ⚠️
cmd/relayproxy/service/gofeatureflag.go 0.00% 7 Missing ⚠️
cmd/relayproxy/config/retriever.go 93.33% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2672      +/-   ##
==========================================
- Coverage   84.91%   84.50%   -0.42%     
==========================================
  Files         105      106       +1     
  Lines        4940     5021      +81     
==========================================
+ Hits         4195     4243      +48     
- Misses        588      616      +28     
- Partials      157      162       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@Abeeujah Abeeujah force-pushed the main branch 2 times, most recently from b83d446 to c1b9b23 Compare November 19, 2024 18:57
@Abeeujah
Copy link
Contributor Author

Hi @thomaspoignant my bad; I didn't update the tests after implementing the InitializableRetriever Interface; it's been fixed now, can you review again? all tests are now passing...

Copy link
Owner

@thomaspoignant thomaspoignant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 LGTM

Signed-off-by: Thomas Poignant <[email protected]>
Copy link

sonarcloud bot commented Nov 21, 2024

@thomaspoignant thomaspoignant merged commit 158e04a into thomaspoignant:main Nov 21, 2024
20 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(feature) Azure Blob Storage retriever
2 participants