Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Azure Blob Storage Exporter #2637

Merged
merged 8 commits into from
Nov 10, 2024
Merged

Conversation

Abeeujah
Copy link
Contributor

@Abeeujah Abeeujah commented Nov 7, 2024

Description

Implementation of Azure Blob Storage Exporter to export data usage of your flags to Azure Blob Storage

Closes issue(s)

Resolve #2559

Checklist

  • I have tested this code
  • I have added unit test to cover this code
  • I have updated the documentation (README.md and /website/docs)
  • I have followed the contributing guide

Copy link

netlify bot commented Nov 7, 2024

Deploy Preview for go-feature-flag-doc-preview ready!

Name Link
🔨 Latest commit 6783426
🔍 Latest deploy log https://app.netlify.com/sites/go-feature-flag-doc-preview/deploys/6730f2d2672e410008d3f2d4
😎 Deploy Preview https://deploy-preview-2637--go-feature-flag-doc-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Nov 7, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 21 lines in your changes missing coverage. Please review.

Project coverage is 84.91%. Comparing base (67e6395) to head (6783426).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
exporter/azureexporter/exporter.go 68.18% 15 Missing and 6 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2637      +/-   ##
==========================================
- Coverage   85.09%   84.91%   -0.18%     
==========================================
  Files         104      105       +1     
  Lines        4857     4940      +83     
==========================================
+ Hits         4133     4195      +62     
- Misses        573      588      +15     
- Partials      151      157       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Abeeujah
Copy link
Contributor Author

Hi @thomaspoignant everything going great? Noticed you've been working on this branch, is there anything you'd have me do instead?

@thomaspoignant
Copy link
Owner

@Abeeujah sorry fir that, I had some issues with the tests and I've refactored them to work with azurite container.
Except that it looks really great 👍

Copy link

sonarcloud bot commented Nov 10, 2024

@thomaspoignant thomaspoignant merged commit 88ebd64 into thomaspoignant:main Nov 10, 2024
20 of 22 checks passed
@Abeeujah
Copy link
Contributor Author

@Abeeujah sorry fir that, I had some issues with the tests and I've refactored them to work with azurite container.
Except that it looks really great 👍

Ooh, I was just trying to be of help...
Seen you merged already, GTG🚀🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(feature) Azure BlobStorage exporter
2 participants