fix(otel): fix resource attribute parsing #2608
Conversation
Signed-off-by: Dave Henderson <[email protected]>
✅ Deploy Preview for go-feature-flag-doc-preview canceled.
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2608 +/- ##
==========================================
- Coverage 85.19% 85.04% -0.16%
==========================================
Files 102 102
Lines 4687 4720 +33
==========================================
+ Hits 3993 4014 +21
- Misses 552 561 +9
- Partials 142 145 +3 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
@hairyhenderson Thanks again for all your work on the OTEL part this is great and it helps me a LOT 👍
Sorry for this one, I should have think about this koanf weird way of managing complex object.
I'll merge this one and will release it in the next version.
| attribs map[string]string) (*resource.Resource, error) { | ||
| attrs := make([]attribute.KeyValue, 0, len(attribs)) | ||
| for k, v := range attribs { | ||
| attrs = append(attrs, attribute.String(k, v)) | ||
| } |
There was a problem hiding this comment.
praise: This is a good catch, I think koanf is messing up things when it is a complex object. This is way better like this, thank you 🙏.
|
|
@thomaspoignant 👋 any chance of a patch release soon so I can get this fix rolled out? 🙇♂️ |
|
@hairyhenderson Yes I will release a version later this week. |
Description
Support for
OTEL_RESOURCE_ATTRIBUTESwas broken as koanf was parsing it, but not as the right type. We need to parse it in a custom way.Closes issue(s)
Fixes #2607
Checklist
README.mdand/website/docs)