-
-
Notifications
You must be signed in to change notification settings - Fork 159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(tracing): Restore OTel tracing support #2482
fix(tracing): Restore OTel tracing support #2482
Conversation
✅ Deploy Preview for go-feature-flag-doc-preview canceled.
|
Signed-off-by: Dave Henderson <[email protected]>
17252d8
to
349be1b
Compare
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2482 +/- ##
==========================================
+ Coverage 85.66% 86.18% +0.52%
==========================================
Files 100 100
Lines 3523 3526 +3
==========================================
+ Hits 3018 3039 +21
+ Misses 382 360 -22
- Partials 123 127 +4 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for this PR, I have no idea why I removed it.
I will release a new version containing the fix.
Description
In #1503, the code that used to call
s.otelService.Init
was accidentally removed. This restores that code.Here's proof of spans once again being sent to a local Alloy/Tempo setup:
Note that I have not written a unit test to cover this, as it's quite difficult to do so with how the OTel SDK is configured currently.
I have some ideas on how tracing support can be made more flexible (through use of
autoexport
primarily, and some other changes). I'll issue a PR for that some other time.Closes issue(s)
Fixes #2479
Checklist
README.md
and/website/docs
)