Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Add precisions on how to use the S3 retriever in the relay-proxy #1879

Merged
merged 3 commits into from
May 14, 2024

Conversation

thomaspoignant
Copy link
Owner

Description

Add precisions on how to use the S3 retriever in the relay-proxy

Copy link

netlify bot commented May 14, 2024

Deploy Preview for go-feature-flag-doc-preview ready!

Name Link
🔨 Latest commit d6b2d31
🔍 Latest deploy log https://app.netlify.com/sites/go-feature-flag-doc-preview/deploys/6643189ce99402000861a7aa
😎 Deploy Preview https://deploy-preview-1879--go-feature-flag-doc-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented May 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.80%. Comparing base (6873eaa) to head (9efd994).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1879   +/-   ##
=======================================
  Coverage   86.80%   86.80%           
=======================================
  Files          95       95           
  Lines        3433     3433           
=======================================
  Hits         2980     2980           
  Misses        349      349           
  Partials      104      104           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Thomas Poignant <[email protected]>
@thomaspoignant thomaspoignant merged commit c982515 into main May 14, 2024
8 of 9 checks passed
@thomaspoignant thomaspoignant deleted the doc-s3-provider branch May 14, 2024 07:54
Copy link

sonarcloud bot commented May 14, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

thomaspoignant added a commit that referenced this pull request Sep 5, 2024
#1879)

* docs: Add precisions how to use S3 retriever in the relay-proxy

Signed-off-by: Thomas Poignant <[email protected]>

* fix: typo

Signed-off-by: Thomas Poignant <[email protected]>

---------

Signed-off-by: Thomas Poignant <[email protected]>
Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant