-
-
Notifications
You must be signed in to change notification settings - Fork 151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Allow to force update the internal cache #1878
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Thomas Poignant <[email protected]>
Signed-off-by: Thomas Poignant <[email protected]>
Signed-off-by: Thomas Poignant <[email protected]>
✅ Deploy Preview for go-feature-flag-doc-preview canceled.
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1878 +/- ##
==========================================
+ Coverage 86.72% 86.80% +0.07%
==========================================
Files 89 95 +6
Lines 3368 3433 +65
==========================================
+ Hits 2921 2980 +59
- Misses 345 349 +4
- Partials 102 104 +2 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Thomas Poignant <[email protected]>
Signed-off-by: Thomas Poignant <[email protected]>
Signed-off-by: Thomas Poignant <[email protected]>
thomaspoignant
force-pushed
the
force-refresh-cache
branch
from
May 13, 2024 20:41
cbe9b45
to
43e48d6
Compare
Signed-off-by: Thomas Poignant <[email protected]>
Signed-off-by: Thomas Poignant <[email protected]>
Signed-off-by: Thomas Poignant <[email protected]>
Signed-off-by: Thomas Poignant <[email protected]>
Signed-off-by: Thomas Poignant <[email protected]>
Quality Gate passedIssues Measures |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds functionality to force the call to the retrievers when we know that a change has happened in the configuration of your flag, it will call the retrievers without having to wait for the next polling interval to happen.
A good example of when to call this new API?
We set the polling interval to a high value (~15 minutes) BUT in the CI process of our flag config file, we explicitly call a function (or API) to refresh the flags configuration.
In the relay proxy
A new endpoint has been added and allows to force refresh the call to the retrievers.
authorizedKeys.admin
.example:
In the go module
If you are using the go module, a new function is available and is called
ffclient.ForceRefresh()
.example:
Before this version, the way to configure your API Keys for the relay proxy was by setting the key
apiKeys
in the relay-proxy configuration file.go-feature-flag/website/docs/relay_proxy/configure_relay_proxy.md
Line 46 in c048469
Now this way of configuring the authorized API keys is deprecated and we are using a key called
authorizedKeys
.go-feature-flag/website/docs/relay_proxy/configure_relay_proxy.md
Line 46 in 21f58bb
go-feature-flag/website/docs/relay_proxy/configure_relay_proxy.md
Lines 54 to 61 in 21f58bb
Closes issue(s)
Resolve #1858
Checklist
README.md
and/website/docs
)