fix(debug): Don't dump bodies larger than 8KiB when debugging #4348
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dave Henderson <[email protected]>
✅ Deploy Preview for go-feature-flag-doc-preview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4348 +/- ##
==========================================
+ Coverage 85.09% 85.18% +0.09%
==========================================
Files 142 143 +1
Lines 5909 5925 +16
==========================================
+ Hits 5028 5047 +19
+ Misses 663 660 -3
Partials 218 218 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
4 tasks
Signed-off-by: Thomas Poignant <[email protected]>
thomaspoignant
approved these changes
Nov 24, 2025
Owner
thomaspoignant
left a comment
thomaspoignant
left a comment
There was a problem hiding this comment.
@hairyhenderson thanks for this PR, I have just updated the doc to be explicit that we can truncate the log.
|
hairyhenderson
deleted the
hairyhenderson/truncate-debug-body-dumps-4346
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related to #4346 (doesn't fully resolve it, there's one more PR to come around that).
This truncates bodies that are larger than 8KiB to avoid unnecessarily large log lines, and large levels of memory consumption. This is only really relevant when debug logging is used, but debug should still be able to be used in production for certain purposes.
Checklist
README.mdand/website/docs)