Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fix: handling of NAs in tranasition_filter #404

Merged
merged 1 commit into from
Mar 12, 2021

Conversation

rsaporta
Copy link
Contributor

PROBLEM:

When there are NAs in the columns used for filtering in transition_filter, possible error:

Error in `$<-.data.frame`(`*tmp*`, "colour", value = "grey") :
  replacement has 1 row, data has 0

Issue tracks down to an if() clause in the assign_filters() function.

SOLUTION:

add na.rm = TRUE to the if clause argument

@rsaporta rsaporta changed the title assign_filters check for NAs Bug fix: handling of NAs in tranasition_filter Sep 12, 2020
@thomasp85 thomasp85 merged commit 3ff7ee1 into thomasp85:master Mar 12, 2021
@thomasp85
Copy link
Owner

Thank you 🙏

VolodiaPG pushed a commit to VolodiaPG/gganimate that referenced this pull request May 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants