fix(shared): correct MCP tool count to 79 in feature-guide copy - #392
Conversation
The published 94 accidentally counted the 15 class-level [McpServerToolType] attributes alongside the 79 [McpServerTool] methods. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review: PR #392 (thomasluizon/orbit-ui-mobile)
Scope: PR #392 — fix(shared): correct MCP tool count to 79 in feature-guide copy
Recommendation: APPROVE
Summary
Two-line diff in packages/shared/src/i18n/en.json and pt-BR.json, correcting the in-app feature-guide string assistantCanDoDesc from "94 tools" to "79 tools" (and the pt-BR equivalent). Pure copy fix, no code/logic/contract changes. Both locales are updated together, no stray "94" mentions remain, and both apps/web and apps/mobile consume the corrected string identically via the shared i18n key with zero hardcoded duplication.
Findings
Critical
None.
High
None.
Medium
None.
Low / Info
Tool-count correction split across two companion PRs
- This PR fixes the in-app copy (79);
FEATURES.mdstill reads "94" in the working tree and is corrected separately in PR #391 (also currently open). The two PRs can merge in either order, producing a brief window where the doc and the in-app string disagree. - Risk: cosmetic only — no functional or contract impact. Not a blocker.
- Optional: merge #391 around the same time to close the window.
"79" count not independently verifiable in this job
orbit-api(sibling repo with the[McpServerTool]attributes) isn't checked out in this CI job, so the count can't be re-derived directly here.- PR #391's body independently lists a 15-class breakdown that sums exactly to 79, corroborating the claim from a second source. Not verifiable in CI per task scope, but corroborating evidence is strong.
Subagents
| Agent | Verdict |
|---|---|
| parity-checker | N/A — no apps/web/** or apps/mobile/** files changed; both apps consume the shared i18n key with no hardcoded duplicate |
| i18n-syncer | IN SYNC — both en.json and pt-BR.json updated at the same key (assistantCanDoDesc), no orphaned "94" remaining in either file |
| contract-aligner | N/A — no packages/shared/src/types/* or endpoints.ts touched |
| security-reviewer | N/A — no orbit-api code in this diff |
What's good
- Both locales corrected in the same PR — exactly the discipline root
CLAUDE.mddemands for i18n changes. - Zero duplication risk: the count lives in exactly one place per locale, consumed identically by both apps.
- PR body is precise about provenance and cross-links the companion
FEATURES.mdfix in #391.
Recommendation
Approve as-is. No code risk, no contract risk, no parity gap.
There was a problem hiding this comment.
Code Review: PR #392
Scope: fix(shared): correct MCP tool count to 79 in feature-guide copy
Recommendation: APPROVE
Summary
Corrects the in-app feature-guide copy (AI Settings "What Your Assistant Can Do") from a stale 94 to 79 MCP tools, matching the count already corrected in FEATURES.md by the now-merged #391. The diff is exactly one string key (assistantCanDoDesc) changed identically in packages/shared/src/i18n/en.json and packages/shared/src/i18n/pt-BR.json — only the numeral differs, both locales updated in the same commit. No other files changed; the subsequent merge-from-main commit brought in unrelated history with no effect on this diff.
Findings
Critical / High / Medium / Low: None.
Subagents
| Agent | Verdict |
|---|---|
| parity-checker | N/A — no apps/web/**/apps/mobile/** files changed; the shared i18n string reaches both platforms automatically |
| i18n-syncer | IN SYNC — explore.mcp.assistantCanDoDesc present at the identical nested path in both locales, number updated consistently in both, no orphaned "94" remaining |
| contract-aligner | N/A — no packages/shared/src/types/* or endpoints.ts touched |
| security-reviewer | N/A — no orbit-api code in this diff |
Validation
Lint/type-check/tests/build: N/A — pure JSON string-literal diff, no behavioral code changed. (Build/Unit Tests/SonarCloud run as separate required CI checks per this PR's setup.)
Not verifiable in CI
Independent re-count of [McpServerTool] methods against orbit-api source to confirm "79" is exact — sibling repo not checked out in this job. Corroborated by #391's 15-class breakdown summing to 79.
What's good
Minimal, targeted, both locales updated together (satisfies root CLAUDE.md's mandatory i18n-parity rule), consistent with the prior FEATURES.md correction.
Recommendation
Safe to merge as-is — no code, contract, or behavioral surface is touched.
|
1 participant
The real count is 79 [McpServerTool] methods across 15 classes; the old 94 also swept in the 15 class-level [McpServerToolType] attributes. FEATURES.md is corrected in #391; this fixes the in-app feature-guide strings (both locales).
🤖 Generated with Claude Code