test(smoke): fix stale paywall radiogroup assertion (unblocks prod smoke) - #340
Merged
Conversation
#327 redesigned the upgrade paywall from a radiogroup plan-selector into the 3-column PricingSection (a PlanCard grid). The post-deploy prod smoke failed on the now-absent getByRole('radiogroup'). The 'paywall-checkout' testid still exists (the yearly hero card CTA), so drop only the obsolete radiogroup line. Prod is healthy — the other 6 smoke tests (auth, create/log habit, Astra) pass. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review PR 340 - APPROVE. Single-line deletion removing a stale getByRole radiogroup assertion from the paywall smoke test. PR 327 redesigned the upgrade page from a radiogroup plan-selector to a PricingSection grid, making the old assertion permanently false. The remaining getByTestId paywall-checkout assertion is confirmed valid - the testid is present in apps/web/components/upgrade/plan-selection.tsx. All subagents N/A (test-only file, no production code changed). No findings. Merge.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unblock the prod smoke — stale paywall assertion
The post-deploy Prod Smoke failed on 1 of 7 tests:
paywall.spec.tsassertedgetByRole('radiogroup'), but #327 redesigned the upgrade page from a radiogroup plan-selector into the 3-columnPricingSection(aPlanCardgrid). Thepaywall-checkouttestid is still present (the yearly hero card's CTA), so the only stale line is theradiogroupassertion — dropped.Prod is healthy — the 4 critical flows (auth, create-habit, log-habit, Astra-creates-habit) and the plans API all passed; only the stale selector failed. No rollback needed.
🤖 Generated with Claude Code