fix: always show the Today filter control (remove <5-habits hide) - #336
Merged
Conversation
Remove the habit-count gate that hid the search/filter/controls entry point for users with few habits. The filter control now renders unconditionally on both platforms. - mobile: drop the showFilters prop and its plumbing in today-habits-header (icon row + tag chips render unconditionally) and the orphaned useTotalHabitCount call/import/useMemo dep in (tabs)/index. - web: drop the `totalHabitCount >= 5` wrapper around TodayUtilityRow in (app)/page and the now-orphaned useTotalHabitCount import/call. - tests: assert the filter row is always present and drop the dead count-mock scaffolding (both platforms). The unrelated upgrade gate (useTotalHabitCount in layout/_layout) is untouched. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
There was a problem hiding this comment.
APPROVE: PR 336 removes the habitCount >= 5 gate that hid the search/filter entry point on both platforms. Clean root-cause deletion of the prop, its callers, and old test scaffolding. No new logic introduced. Zero Critical/High/Medium findings. Parity: PAIRED on both platforms. i18n: IN SYNC. Contract: N/A. Security: N/A. Lint/type-check/tests all pass per PR body. useTotalHabitCount correctly retained in both layouts for the unrelated >=10 free-tier gate. Generated with Claude Code.
|
thomasluizon
added a commit
that referenced
this pull request
Aug 19, 2026
…he five missing surfaces (#36) The canvas is the design of record now, and nothing said so where a worker would read it. /orchestrate reads the ticket, not the project. Twenty one existing tickets gained a comment naming the document that defines their surface. Their bodies were already corrected against D69 on 2026-08-16, so the comment adds the drawing rather than restating the job, and says plainly that the document is the later artefact where the two differ. Five surfaces gained a document in this run and had no ticket at all: #335 the notification bell and its list Orbit Avisos #336 search results, including which matched Orbit Busca #337 the step up code screen Orbit Verificacao #338 the error and static surfaces Orbit Estados #339 offline, and the dropped change Orbit Offline #335 is ordered behind #334, because rewriting the client while the server still writes /streak leaves the two disagreeing. #336 needs no API work at all: the server already returns searchMatches and computeHabitMatchBadges has zero consumers, so the app has been throwing away a better result than it draws. D4, the fourth system round, landed five of nine. The canvas read the whole brief, judged it lacked the headroom to build nine components plus their cards without leaving the system half edited, and wrote nothing that round rather than risk it. Sheet's mount contract, CapacityNotice's body, the Skeleton grid variant, the ListRow read only variant and EventRow are done. DayCell and MonthGrid, OtpInput, Pager and Columns stay on its todo list. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Always show the Today/Habits filter
Removes the
habitCount >= 5gate that hid the search/filter entry point for users with few habits — the filter is now always visible (per request, this feature is being reverted).Removed (root-cause, both platforms)
today-habits-header.tsxshowFiltersprop + the two gated blocks (icons + tag chips now unconditional);(tabs)/index.tsxtheshowFiltersprop + orphaneduseTotalHabitCountplumbing.(app)/page.tsxthetotalHabitCount >= 5 &&wrapper + orphaneduseTotalHabitCount.The unrelated free-tier upgrade gate (
>= 10habits) is untouched.Validation
type-check 3/3; lint 0 errors; tests green (web today-page 19/19, mobile today-screen 20/20).
🤖 Generated with Claude Code