mobile fixes - #15
Merged
Merged
mobile fixes#15
Conversation
thomasluizon
commented
Apr 7, 2026
thomasluizon
commented
Owner
- mobile: add habit delete flow & push handling
- mobile: drill navigation, UI & push improvements
- Mobile: UI tweaks, push token fix, and APK script
- fix push notification registration flow
Multiple mobile changes: add a habit delete confirmation flow (request/confirm, modal, and onDelete wiring) and surface a TrialBanner in the Today screen. Improve push notification handling: open settings if permission denied, refresh permission status on app resume, and move PushPrompt lazy-loading logic to a safer location. UX fixes: better keyboard handling for the Profile "Fresh Start" modal (KeyboardAvoidingView + ScrollView, maxHeight), show an action to open settings when mic access is denied in Chat, and adjust related styles. Tests: update api-client tests to mock text responses and add a test for successful empty 200 responses. Config: update app.json Android adaptive icon foreground and add POST_NOTIFICATIONS and RECORD_AUDIO permissions. Repo housekeeping: expand .gitignore rules for native build outputs and remove generated Android build artifacts from orbit-widget; add/update web/mobile assets and i18n updates.
Add drill-into view and refine habit UI and push handling. - Introduce drill navigation in HabitList (useDrillNavigation): renders a drill header with back/reset, shows only sub-habits for a drilled parent, and provides an add-sub-habit action. - Update HabitList to wire drill.drillInto and adapt onForceLogParent to call an optional onLogHabit prop. - Refactor HabitCard touch behavior: replace outer TouchableOpacity with an inner pressable area, simplify expand toggle handler, reorder title/description rendering and adjust styles to avoid interaction conflicts. - Improve push notification handling: remove automatic permission request from PushPrompt, use ExecutionEnvironment checks from expo-constants to detect StoreClient/Expo Go, and harden permission/token flow in use-push-notifications. - Add googleServicesFile to app.json for Android native config. - Add convenience scripts and wiring: new scripts run-android.js, run-dev-client.js, android-release-device.js and update package.json to use them for dev/client/android commands. (Excluded autogenerated build/intermediates changes.)
Multiple mobile app updates: - bottom-sheet-modal: stabilize snapPoints useMemo by keying on a joined snapPoints string to avoid stale deps when array identity changes. - habit-card: make the whole card pressable (TouchableOpacity) and remove nested pressable to simplify touch handling; adjust styles accordingly and add long-press to enter select mode. - habits/log-habit-modal: replace Gorhom bottom sheet with a native Modal + KeyboardAvoidingView, add custom sheet header with close button, backdrop handling, and platform-aware keyboard behavior for improved UX. - ui/push-prompt: auto-request notification permission once when status is undetermined (with a small Android delay), track auto-request to avoid repeated prompts. - hooks/use-push-notifications: ensure Android uses native FCM token only (never fall back to Expo token) so backend delivery via FCM works reliably; streamline token retrieval logic. - package.json + scripts: add npm script "android:apk" and new scripts/android-release-apk.js to run gradle assembleRelease with EXPO_NO_METRO_WORKSPACE_ROOT set. These changes improve touch handling, modal UX, push notification reliability on Android, and add a convenience script for building a release APK.
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b93ca1fd85
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Comment on lines
+67
to
+71
| const interaction = InteractionManager.runAfterInteractions(() => { | ||
| timeoutId = setTimeout(() => { | ||
| if (cancelled) return | ||
| void requestPermission().then((success) => { | ||
| if (success) { |
There was a problem hiding this comment.
The effect now auto-calls requestPermission() as soon as permission is undetermined, but that branch runs before the stored dismissal flag is checked. As a result, users who tapped “Not now” (which sets orbit_push_prompted in dismiss) can still be forced into the OS permission dialog on the next launch, effectively ignoring their deferral choice and causing repeated unsolicited prompts until they deny/grant at the system level.
Useful? React with 👍 / 👎.
|
3 tasks
This was referenced Jul 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.