Skip to content

fix sonar mobile scope and coverage - #13

Merged
thomasluizon merged 1 commit into
mainfrom
fix/sonar-mobile-scope-and-tests
Apr 6, 2026
Merged

fix sonar mobile scope and coverage#13
thomasluizon merged 1 commit into
mainfrom
fix/sonar-mobile-scope-and-tests

Conversation

@thomasluizon

Copy link
Copy Markdown
Owner

No description provided.

@vercel

vercel Bot commented Apr 6, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated (UTC)
orbit-ui-mobile-web Ignored Ignored Apr 6, 2026 2:09pm

@thomasluizon
thomasluizon merged commit 6b3617e into main Apr 6, 2026
4 checks passed
@sonarqubecloud

sonarqubecloud Bot commented Apr 6, 2026

Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
70.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 84007f9725

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

const headers: Record<string, string> = {
...(options.headers ?? {}),
}
const headers: Record<string, string> = options.headers ?? {}

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Clone headers before mutating request metadata

apiClient now aliases options.headers directly and then mutates it by adding auth/content-type fields, which introduces hidden side effects for callers that reuse a headers object across requests. In that case, one JSON request can permanently inject Content-Type: application/json into the shared object and break later FormData uploads (wrong boundary/content type), so this should keep copying headers before mutation as it did previously.

Useful? React with 👍 / 👎.

Comment on lines 1093 to 1095
<div
role="button"
tabIndex={0}
className={`${articleClassName} text-left w-full`}

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Restore button semantics on clickable habit cards

This element is still focusable and handles Enter/Space, but removing role="button" strips the control semantics that assistive technologies rely on to announce it as an actionable UI element. Keyboard users can still activate it, but screen-reader users will no longer get proper button affordance for the primary card action, so this is an accessibility regression unless the container is converted to a native <button>.

Useful? React with 👍 / 👎.

@thomasluizon
thomasluizon deleted the fix/sonar-mobile-scope-and-tests branch April 6, 2026 14:29
thomasluizon added a commit that referenced this pull request Jun 27, 2026
…olish (#8, #13) (#326)

Year-skip arrows on month nav (both platforms). Month-stats redesigned as a data-driven extensible StatTile grid. Web: view switcher (Month/Week/Range) + Google-Calendar-style time-grid (hourly rows, day columns, timed-habit blocks, all-day band, now-line) for week + custom contiguous-range; mobile keeps month. Sync screen: Sincronizar agora->Sincronizar, deselect-all text->icon button. web+mobile parity for shared parts; grids web-only by design; both locales.

Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant