chore: delete the Harness Lockstep job, whose tool no longer exists - #450
Merged
Conversation
The job ran `orbit-ui-mobile/tools/check-lockstep.mjs`. That file was deleted by the harness rebuild (orbit-ui-mobile #676, 2026-08-04), so every run since has died with MODULE_NOT_FOUND before doing any work. Run 30935791677 on main, 2026-08-04T17:50:54Z, is the proof: `Error: Cannot find module '.../orbit-ui-mobile/tools/check-lockstep.mjs'`, exit code 1. It is not a required context on main (13 contexts, none of them Harness Lockstep), so it blocked nothing. It only produced a permanently red check on every push and pull request. The two pr-review clauses went with it: both said the lockstep run "soon will not run at all", written while the deletion was still pending. It is now gone, so the sentence describes a job that no longer exists. Kept deliberately, checked rather than assumed: mutation.yml (284 runs) and benchmark.yml (20 of 20 green nightly), both of which a previous deletion list wrongly called dead. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Staleness audit of every tracked file in orbit-api (1,672 files) after the 2026-08-04 harness rebuild. One deletion survived adversarial verification. Everything else is listed below with the reason it stays.
Deleted
.github/workflows/guards.yml: thelockstepjob (91 lines)Class: dead reference + a CI job that fails every run.
The job's only real step was:
check-lockstep.mjswas deleted from orbit-ui-mobile by the harness rebuild (#676). Live evidence, not inferred:That is the most recent
pushrun onmain, 2026-08-04T17:50:54Z. The four most recentguards.ymlruns are allfailurefor this reason.It was safe to remove because it blocks nothing:
13 contexts,
Harness Lockstepis not one of them. It produced a permanently red check and nothing else.Two clauses in
.claude/skills/pr-review/{SKILL.md,rubric.md}Both said the lockstep run "blocks nothing and soon will not run at all". Written while the deletion was still pending; this PR performs it, so the sentence now describes a job that does not exist. Removed the clause only; the surrounding twin-discipline paragraph is unchanged.
Considered and kept, with the reason
Every one of these was checked against the live system, never against a document.
.github/workflows/mutation.yml.github/workflows/benchmark.ymlarch-map.yml(58),codeql.yml(19),dependabot-auto-merge.yml(404),dependency-review.yml(256),sonarcloud.yml(814),test.yml(711)opencode.json,.opencode/agents/*.mdCLAUDE.md:52says so explicitly: "opencode remains live in THIS repo viaopencode.json,.opencode/agents/*.md, and the/second-opinionskill."opencode.jsonloadstests/CLAUDE.md, which exists.tools/check-frontmatter.mjsSkill and Agent Frontmatterjob. Ran green in the same failing run above.tools/check-push-target.mjslefthook.yml.tools/arch-map.mjsarch-map.yml, generates the committedarchitecture.json/architecture.html.bench/baseline.jsonbenchmark.yml:33viacheck_bench.py.load-tests/**(10 files)sonarcloud.yml:80deliberately excludes it as such. Ruled out "orphan": it is an entry point, not a library..config/dotnet-tools.jsonmutation.yml:40runsdotnet tool restore; this file is what it restores.CodeMetricsConfig.txtDirectory.Build.props..github/scripts/check_coverage.py,check_migration_idempotency.pytest.yml:66andtest.yml:124.stryker-config.{application,domain,infrastructure}.jsonmutation.yml..claudeignore.claude/agents/{contract-aligner,security-reviewer}.mdpr-review/SKILL.mdandrubric.md.AGENTS.md:29,CLAUDE.md:34"lockstep"No tracked-but-gitignored files.
git ls-files -i -c --exclude-standardreturns empty in this repo.No agent scratch, no empty or stub files, no orphaned source.
Drifted twins, reported not deleted
check-lockstep.mjsused to compare six files against orbit-ui-mobile. Nothing compares them now. Measured drift today:.claude/skills/pr-review/rubric.md.claude/skills/pr-review/SKILL.md.claude/skills/_shared/verification-protocol.md.claude/skills/second-opinion/SKILL.md.claude/hooks/git-guardrails.mjs.claude/skills/second-opinion/second-opinion.mjsDrift is not death, so nothing here was deleted. Much of it is legitimate divergence the rubric itself documents (backend-only dimensions here, harness-execution evidence there). Whether the gate should come back, in a form that does not depend on a sibling checkout, is a decision for a ticket rather than this PR.
Could not determine
.claudeignore(this repo and orbit-ui-mobile). I could not confirm from the live system whether Claude Code still reads it. It is kept, because deleting a convention-discovered config on an unverified belief is exactly the failure this audit exists to avoid. What would settle it: the current Claude Code docs, or a run with a file matched by.claudeignoreobserved being excluded.Gates
guards.ymlshould go green on this PR for the first time since 2026-08-04.Not merged. Yours to merge.
Generated with Claude Code