Skip to content

chore(sonar): suppress S3459 false positives on EF backing fields (#243) #399

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
thomasluizon merged 2 commits into from
Jul 14, 2026
Merged

chore(sonar): suppress S3459 false positives on EF backing fields (#243) #399

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
283d1e7
chore(sonar): suppress S3459 false positives on EF backing fields (#243)
thomasluizon Jul 14, 2026
8f526e7
Merge branch 'main' into chore/api-suppress-s3459-ef-backing-fields
thomasluizon Jul 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/Orbit.Domain/Entities/PendingClarification.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,9 +19,9 @@ public class PendingClarification : Entity
public DateTime CreatedAtUtc { get; private set; }
public DateTime ExpiresAtUtc { get; private set; }

#pragma warning disable CS0649 // Written only at the SQL layer via ExecuteUpdate and read back via reflection on materialization; there is no C# writer, which is what removes the S1144 unused-private-setter finding. https://github.com/thomasluizon/orbit-api/pull/390
#pragma warning disable CS0649, S3459 // Written only at the SQL layer via ExecuteUpdate and read back via reflection on materialization; there is no C# writer, so both CS0649 (never-assigned) and Sonar S3459 (unassigned field) are false positives here. https://github.com/thomasluizon/orbit-api/pull/390
private DateTime? _resolvedAtUtc;
#pragma warning restore CS0649
#pragma warning restore CS0649, S3459

/// <summary>
/// UTC instant this clarification was resolved; null while still open. Exposed as a read-only
Expand Down
4 changes: 2 additions & 2 deletions src/Orbit.Domain/Entities/Report.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,9 +13,9 @@ public class Report : Entity
public ReportStatus Status { get; private set; }
public DateTime CreatedAtUtc { get; private set; }

#pragma warning disable CS0649 // EF writes this backing field via reflection on materialization; there is no C# writer, which is what removes the S1144 unused-private-setter finding. https://github.com/thomasluizon/orbit-api/pull/390
#pragma warning disable CS0649, S3459 // EF writes this backing field via reflection on materialization and at the SQL layer; there is no C# writer, so both CS0649 (never-assigned) and Sonar S3459 (unassigned field) are false positives here. https://github.com/thomasluizon/orbit-api/pull/390
private DateTime? _reviewedAtUtc;
#pragma warning restore CS0649
#pragma warning restore CS0649, S3459

/// <summary>
/// UTC instant an admin reviewed this report; null until reviewed. Exposed as a read-only
Expand Down
Loading