Skip to content

fix(api): idempotent handle-index migration — unblock prod deploy (#243) #345

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
thomasluizon merged 1 commit into from
Jul 12, 2026
Merged

fix(api): idempotent handle-index migration — unblock prod deploy (#243) #345

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/Orbit.Infrastructure/Migrations/20260712120428_AddUserHandleUniqueIndex.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,9 +25,9 @@ PARTITION BY LOWER(""Handle"")
FROM ranked
WHERE u.""Id"" = ranked.""Id"" AND ranked.rn > 1;");

// Handles are compared case-insensitively app-wide (LOWER(Handle) == normalized), so a plain unique index would let 'Bob'/'bob' coexist and skip the lookup; Npgsql has no fluent functional-index API, so it lives in SQL. https://github.com/thomasluizon/orbit-ui-mobile/issues/243
// Idempotent: an identical IX_Users_Handle_Lower was already created by AddSocialFoundation, so a bare CREATE crashes prod migration with 42P07 (relation already exists) while tests — which never run raw-SQL migrations against real Postgres — pass. IF NOT EXISTS makes this a safe no-op on existing DBs and still correct on a fresh one. https://github.com/thomasluizon/orbit-ui-mobile/issues/243
migrationBuilder.Sql(@"
CREATE UNIQUE INDEX ""IX_Users_Handle_Lower""
CREATE UNIQUE INDEX IF NOT EXISTS ""IX_Users_Handle_Lower""
ON ""Users"" (LOWER(""Handle""))
WHERE ""Handle"" IS NOT NULL;");
}
Expand Down
Loading