Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions .claude/skills/pr-review/SKILL.md
Original file line number Diff line number Diff line change
Expand Up @@ -98,11 +98,13 @@ Go dimension-by-dimension through `rubric.md` against the diff. For each, emit f
in the rubric's finding template, tagged with a severity from the ladder. Honor the
gates: skip a dimension whose surface the diff never touches (mark N/A — do not invent
findings), and only run the UI dimension (DESIGN.md / AI-slop, #8) when `apps/*` UI
files changed, the backend hard rules (#13) only when `orbit-api` changed.
files changed, the backend hard rules (#13) only when `orbit-api` changed, and
FEATURES.md parity (#14) only when the diff changes the user-facing feature surface.

The dimensions, in order: Correctness · Dead/stale code · SOLID/clean-arch · Comment
policy · No-workaround · Type safety · No `console.log` · DESIGN.md/AI-slop ·
Parity · i18n · Contract drift + backward-compat · Security · Backend hard rules.
Parity · i18n · Contract drift + backward-compat · Security · Backend hard rules ·
FEATURES.md parity.

Focus on changed code, not pre-existing issues — unless a pre-existing issue is Critical.

Expand Down
21 changes: 21 additions & 0 deletions .claude/skills/pr-review/rubric.md
Original file line number Diff line number Diff line change
Expand Up @@ -298,6 +298,27 @@ options are enforced server-side.
- **Tests**: every new command/query handler, validator, and service has a unit test
(unit only — no integration or E2E suite exists).

### 14. FEATURES.md parity (feature inventory)

> Reference: `FEATURES.md` at the orbit-ui-mobile repo root — the code-derived feature
> inventory (#378). **Gated: only when the diff changes the user-facing feature surface.**

- Triggers: a feature added, materially changed, or removed — new screen/route/tab, new
or removed Astra (`IAiTool`) or MCP (`[McpServerTool]`) tool, plan-gating change
(`PayGateService` / `AppConstants`), platform-availability change, or locale-specific
behavior change. Pure refactors, bugfixes, and visual polish with no behavior change
are N/A.
- The same PR updates `FEATURES.md` — row added, edited, or removed, with the Gating /
Platform / Locale columns still accurate, and the stated tool counts corrected when
tools are added or removed. A missing update is **High** (same bar as a missing
web↔mobile mirror); a gating or platform claim the diff makes stale is **High** too.
- Headline-set features (Astra, MCP, social, core tracker) also surface in the in-app
feature guide (`onboarding.featureGuide.*`) — if the change makes the guide wrong or
incomplete, flag it (**Medium**).
- In the orbit-api repo the file is not in the checkout: do not verify — emit the
finding as "FEATURES.md update required in thomasluizon/orbit-ui-mobile" (**High**)
so it lands in the paired frontend PR.

---

## Self-review note
Expand Down

This file was deleted.

243 changes: 0 additions & 243 deletions description.md

This file was deleted.

Loading