Repository navigation
chore(nuclear-review): behavior-preserving structural review — orbit-api - #253
Quality Gate failed
Failed conditions
Annotations
Check warning on line 166 in src/Orbit.Application/Chat/Commands/ProcessUserChatCommand.Ai.cs
sonarqubecloud / SonarCloud Code Analysis
Either remove or fill this block of code.
See more on https://sonarcloud.io/project/issues?id=thomasluizon_orbit-api&issues=AZ7_oBnFY4bzxJ9Dq5pO&open=AZ7_oBnFY4bzxJ9Dq5pO&pullRequest=253
sonarqubecloud / SonarCloud Code Analysis
Loops should be simplified using the "Where" LINQ method
See more on https://sonarcloud.io/project/issues?id=thomasluizon_orbit-api&issues=AZ7_oBnsY4bzxJ9Dq5pR&open=AZ7_oBnsY4bzxJ9Dq5pR&pullRequest=253
Check warning on line 95 in src/Orbit.Application/Chat/Commands/ProcessUserChatCommand.Ai.cs
sonarqubecloud / SonarCloud Code Analysis
Method has 8 parameters, which is greater than the 7 authorized.
See more on https://sonarcloud.io/project/issues?id=thomasluizon_orbit-api&issues=AZ7_oBnFY4bzxJ9Dq5pP&open=AZ7_oBnFY4bzxJ9Dq5pP&pullRequest=253
Check warning on line 42 in src/Orbit.Api/Controllers/SyncControllerMutations.cs
sonarqubecloud / SonarCloud Code Analysis
Make 'ApplyEntityMutationAsync' a static method.
See more on https://sonarcloud.io/project/issues?id=thomasluizon_orbit-api&issues=AZ7_oBg3Y4bzxJ9Dq5pJ&open=AZ7_oBg3Y4bzxJ9Dq5pJ&pullRequest=253
Check warning on line 278 in src/Orbit.Application/Chat/Commands/ProcessUserChatCommand.Tools.cs
sonarqubecloud / SonarCloud Code Analysis
Method has 8 parameters, which is greater than the 7 authorized.
See more on https://sonarcloud.io/project/issues?id=thomasluizon_orbit-api&issues=AZ7_oBm9Y4bzxJ9Dq5pM&open=AZ7_oBm9Y4bzxJ9Dq5pM&pullRequest=253
Check warning on line 42 in src/Orbit.Api/Controllers/SyncControllerMutations.cs
sonarqubecloud / SonarCloud Code Analysis
Member 'ApplyEntityMutationAsync' does not access instance data and can be marked as static
See more on https://sonarcloud.io/project/issues?id=thomasluizon_orbit-api&issues=AZ7_oBg3Y4bzxJ9Dq5pL&open=AZ7_oBg3Y4bzxJ9Dq5pL&pullRequest=253
Check warning on line 51 in src/Orbit.Api/Controllers/SyncControllerMutations.cs
sonarqubecloud / SonarCloud Code Analysis
Prefer using 'string.Equals(string, StringComparison)' to perform a case-insensitive comparison, but keep in mind that this might cause subtle changes in behavior, so make sure to conduct thorough testing after applying the suggestion, or if culturally sensitive comparison is not required, consider using 'StringComparison.OrdinalIgnoreCase'
See more on https://sonarcloud.io/project/issues?id=thomasluizon_orbit-api&issues=AZ7_oBg3Y4bzxJ9Dq5pK&open=AZ7_oBg3Y4bzxJ9Dq5pK&pullRequest=253
Check warning on line 91 in src/Orbit.Application/Chat/Commands/ProcessUserChatCommand.Tools.cs
sonarqubecloud / SonarCloud Code Analysis
Change type of parameter 'orderedCalls' from 'System.Collections.Generic.IReadOnlyList<Orbit.Domain.Models.AiToolCall>' to 'System.Collections.Generic.List<Orbit.Domain.Models.AiToolCall>' for improved performance
See more on https://sonarcloud.io/project/issues?id=thomasluizon_orbit-api&issues=AZ7_oBm9Y4bzxJ9Dq5pN&open=AZ7_oBm9Y4bzxJ9Dq5pN&pullRequest=253
sonarqubecloud / SonarCloud Code Analysis
Change this condition so that it does not always evaluate to 'False'.
See more on https://sonarcloud.io/project/issues?id=thomasluizon_orbit-api&issues=AZ7_oBnkY4bzxJ9Dq5pQ&open=AZ7_oBnkY4bzxJ9Dq5pQ&pullRequest=253
sonarqubecloud / SonarCloud Code Analysis
Change return type of method 'ExtractRelatedSurfaces' from 'System.Collections.Generic.IEnumerable<string>' to 'System.Collections.Generic.List<string>' for improved performance
See more on https://sonarcloud.io/project/issues?id=thomasluizon_orbit-api&issues=AZ7_oBnsY4bzxJ9Dq5pS&open=AZ7_oBnsY4bzxJ9Dq5pS&pullRequest=253