Skip to content

feat(api): chat AI tools — tag CRUD, full executor routing, declarative ordering #185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
thomasluizon merged 1 commit into from
Jun 5, 2026
Merged

feat(api): chat AI tools — tag CRUD, full executor routing, declarative ordering #185

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions src/Orbit.Api/Extensions/ServiceCollectionExtensions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -214,6 +214,12 @@ public static WebApplicationBuilder AddOrbitAiServices(this WebApplicationBuilde
builder.Services.AddScoped<IAiTool, GetDailySummaryTool>();
builder.Services.AddScoped<IAiTool, GetRetrospectiveTool>();
builder.Services.AddScoped<IAiTool, GetHabitMetricsTool>();
builder.Services.AddScoped<IAiTool, ListTagsTool>();
builder.Services.AddScoped<IAiTool, CreateTagTool>();
builder.Services.AddScoped<IAiTool, UpdateTagTool>();
builder.Services.AddScoped<IAiTool, DeleteTagTool>();
builder.Services.AddScoped<IAiTool, ReorderGoalsTool>();
builder.Services.AddScoped<IAiTool, GetReferralCodeTool>();
builder.Services.AddScoped<AiToolRegistry>();
builder.Services.AddSingleton<ISystemPromptBuilder, SystemPromptBuilder>();

Expand Down
129 changes: 64 additions & 65 deletions src/Orbit.Api/Mcp/Tools/GoalTools.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,16 +1,23 @@
using System.ComponentModel;
using System.Globalization;
using System.Security.Claims;
using MediatR;
using ModelContextProtocol.Server;
using Orbit.Application.Goals.Commands;
using Orbit.Application.Goals.Queries;
using Orbit.Domain.Enums;

namespace Orbit.Api.Mcp.Tools;

/// <summary>
/// MCP goal tools. Mutations route through <see cref="McpExecutorBridge"/> →
/// <see cref="Orbit.Domain.Interfaces.IAgentOperationExecutor"/> with
/// <see cref="Orbit.Domain.Models.AgentExecutionSurface.Mcp"/>, sharing the policy evaluation
/// (read-only-credential denial, ownership pre-check, Pro/feature-flag gating) and the
/// <c>AgentAuditLogs</c> trail used by every other agent surface; each forwards a snake_case
/// argument object matching its backing <c>IAiTool</c> schema and formats the result into the
/// legacy string contract. Read/query tools stay on MediatR.
/// </summary>
[McpServerToolType]
public class GoalTools(IMediator mediator)
public class GoalTools(IMediator mediator, McpExecutorBridge executorBridge)
{
private static readonly System.Text.Json.JsonSerializerOptions CaseInsensitiveJsonOptions = new() { PropertyNameCaseInsensitive = true };
[McpServerTool(Name = "list_goals"), Description("List all goals for the authenticated user.")]
Expand Down Expand Up @@ -55,24 +62,19 @@ public async Task<string> CreateGoal(
[Description("Goal type: Standard (default) or Streak")] string type = "Standard",
CancellationToken cancellationToken = default)
{
var userId = GetUserId(user);
var goalType = Enum.TryParse<GoalType>(type, ignoreCase: true, out var parsedType)
? parsedType
: GoalType.Standard;

var command = new CreateGoalCommand(
userId,
var result = await executorBridge.ExecuteAsync(user, "create_goal", new
{
title,
description,
targetValue,
target_value = targetValue,
unit,
McpInputParser.ParseOptionalDate(deadline, "deadline"),
Type: goalType);
description,
deadline,
goal_type = type
}, confirmationToken: null, cancellationToken);

var result = await mediator.Send(command, cancellationToken);
return result.IsSuccess
? $"Created goal '{title}' (id: {result.Value})"
: $"Error: {result.Error}";
return result.Succeeded
? $"Created goal '{title}' (id: {result.TargetId})"
: result.Message;
}

[McpServerTool(Name = "get_goal"), Description("Get detailed information about a specific goal by ID, including progress history and linked habits.")]
Expand Down Expand Up @@ -113,34 +115,32 @@ public async Task<string> UpdateGoal(
[Description("Optional deadline in YYYY-MM-DD format")] string? deadline = null,
CancellationToken cancellationToken = default)
{
var userId = GetUserId(user);
var command = new UpdateGoalCommand(
userId,
McpInputParser.ParseGuid(goalId, "goalId"),
var result = await executorBridge.ExecuteAsync(user, "update_goal", new
{
goal_id = goalId,
title,
description,
targetValue,
target_value = targetValue,
unit,
McpInputParser.ParseOptionalDate(deadline, "deadline"));
description,
deadline
}, confirmationToken: null, cancellationToken);

var result = await mediator.Send(command, cancellationToken);
return result.IsSuccess
? $"Updated goal {goalId}"
: $"Error: {result.Error}";
return result.Succeeded ? $"Updated goal {goalId}" : result.Message;
}

[McpServerTool(Name = "delete_goal"), Description("Delete a goal by ID.")]
public async Task<string> DeleteGoal(
ClaimsPrincipal user,
[Description("The goal ID (GUID)")] string goalId,
[Description("Confirmation token returned by confirm_agent_operation_v2 (required: deleting a goal is destructive)")] string? confirmationToken = null,
CancellationToken cancellationToken = default)
{
var userId = GetUserId(user);
var command = new DeleteGoalCommand(userId, McpInputParser.ParseGuid(goalId, "goalId"));
var result = await mediator.Send(command, cancellationToken);
return result.IsSuccess
? $"Deleted goal {goalId}"
: $"Error: {result.Error}";
var result = await executorBridge.ExecuteAsync(user, "delete_goal", new
{
goal_id = goalId
}, confirmationToken, cancellationToken);

return result.Succeeded ? $"Deleted goal {goalId}" : result.Message;
}

[McpServerTool(Name = "update_goal_progress"), Description("Update a goal's current progress value.")]
Expand All @@ -151,17 +151,16 @@ public async Task<string> UpdateGoalProgress(
[Description("Optional note about this progress update")] string? note = null,
CancellationToken cancellationToken = default)
{
var userId = GetUserId(user);
var command = new UpdateGoalProgressCommand(
userId,
McpInputParser.ParseGuid(goalId, "goalId"),
currentValue,
note);

var result = await mediator.Send(command, cancellationToken);
return result.IsSuccess
var result = await executorBridge.ExecuteAsync(user, "update_goal_progress", new
{
goal_id = goalId,
current_value = currentValue,
note
}, confirmationToken: null, cancellationToken);

return result.Succeeded
? $"Updated progress for goal {goalId} to {currentValue}"
: $"Error: {result.Error}";
: result.Message;
}

[McpServerTool(Name = "update_goal_status"), Description("Change a goal's status (Active, Completed, or Abandoned).")]
Expand All @@ -171,13 +170,13 @@ public async Task<string> UpdateGoalStatus(
[Description("New status: Active, Completed, or Abandoned")] string status,
CancellationToken cancellationToken = default)
{
var userId = GetUserId(user);
var newStatus = Enum.Parse<GoalStatus>(status, true);
var command = new UpdateGoalStatusCommand(userId, McpInputParser.ParseGuid(goalId, "goalId"), newStatus);
var result = await mediator.Send(command, cancellationToken);
return result.IsSuccess
? $"Updated goal {goalId} status to {status}"
: $"Error: {result.Error}";
var result = await executorBridge.ExecuteAsync(user, "update_goal_status", new
{
goal_id = goalId,
status
}, confirmationToken: null, cancellationToken);

return result.Succeeded ? $"Updated goal {goalId} status to {status}" : result.Message;
}

[McpServerTool(Name = "reorder_goals"), Description("Reorder goals by setting new positions.")]
Expand All @@ -186,18 +185,17 @@ public async Task<string> ReorderGoals(
[Description("JSON array of objects with 'id' (GUID) and 'position' (int)")] string positionsJson,
CancellationToken cancellationToken = default)
{
var userId = GetUserId(user);
var items = System.Text.Json.JsonSerializer.Deserialize<List<GoalPositionDto>>(
positionsJson,
CaseInsensitiveJsonOptions)
?? [];

var positions = items.Select(p => new GoalPositionUpdate(McpInputParser.ParseGuid(p.Id, "id"), p.Position)).ToList();
var command = new ReorderGoalsCommand(userId, positions);
var result = await mediator.Send(command, cancellationToken);
return result.IsSuccess
? $"Reordered {positions.Count} goals"
: $"Error: {result.Error}";
var result = await executorBridge.ExecuteAsync(user, "reorder_goals", new
{
positions = items.Select(p => new { goal_id = p.Id, position = p.Position })
}, confirmationToken: null, cancellationToken);

return result.Succeeded ? $"Reordered {items.Count} goals" : result.Message;
}

[McpServerTool(Name = "link_habits_to_goal"), Description("Link habits to a goal. Pass the full list of habit IDs (replaces existing links).")]
Expand All @@ -207,15 +205,16 @@ public async Task<string> LinkHabitsToGoal(
[Description("Comma-separated habit IDs (GUIDs)")] string habitIds,
CancellationToken cancellationToken = default)
{
var userId = GetUserId(user);
var ids = habitIds.Split(',', StringSplitOptions.RemoveEmptyEntries | StringSplitOptions.TrimEntries)
.Select(s => McpInputParser.ParseGuid(s, "habitIds")).ToList();

var command = new LinkHabitsToGoalCommand(userId, McpInputParser.ParseGuid(goalId, "goalId"), ids);
var result = await mediator.Send(command, cancellationToken);
return result.IsSuccess
? $"Linked {ids.Count} habits to goal {goalId}"
: $"Error: {result.Error}";
var result = await executorBridge.ExecuteAsync(user, "link_habits_to_goal", new
{
goal_id = goalId,
habit_ids = ids.Select(i => i.ToString())
}, confirmationToken: null, cancellationToken);

return result.Succeeded ? $"Linked {ids.Count} habits to goal {goalId}" : result.Message;
}

[McpServerTool(Name = "get_goal_metrics"), Description("Get metrics for a goal: progress percentage, velocity, projected completion, and linked habit adherence.")]
Expand Down
47 changes: 28 additions & 19 deletions src/Orbit.Api/Mcp/Tools/NotificationTools.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,13 +2,21 @@
using System.Security.Claims;
using MediatR;
using ModelContextProtocol.Server;
using Orbit.Application.Notifications.Commands;
using Orbit.Application.Notifications.Queries;

namespace Orbit.Api.Mcp.Tools;

/// <summary>
/// MCP notification tools. Mutations route through <see cref="McpExecutorBridge"/> →
/// <see cref="Orbit.Domain.Interfaces.IAgentOperationExecutor"/> with
/// <see cref="Orbit.Domain.Models.AgentExecutionSurface.Mcp"/> for shared policy evaluation and the
/// <c>AgentAuditLogs</c> trail. <c>mark_notification_read</c>/<c>mark_all_notifications_read</c> map
/// to the consolidated <c>update_notifications</c> chat tool and <c>delete_notification</c> maps to
/// <c>delete_notifications</c>, each via an <c>action</c> discriminator; the destructive delete
/// accepts and forwards a confirmation token. The <c>get_notifications</c> read stays on MediatR.
/// </summary>
[McpServerToolType]
public class NotificationTools(IMediator mediator)
public class NotificationTools(IMediator mediator, McpExecutorBridge executorBridge)
{
[McpServerTool(Name = "get_notifications"), Description("Get the user's notifications (up to 50, newest first) with unread count.")]
public async Task<string> GetNotifications(
Expand Down Expand Up @@ -37,41 +45,42 @@ public async Task<string> MarkNotificationRead(
[Description("The notification ID (GUID)")] string notificationId,
CancellationToken cancellationToken = default)
{
var userId = GetUserId(user);
var command = new MarkNotificationReadCommand(userId, McpInputParser.ParseGuid(notificationId, "notificationId"));
var result = await mediator.Send(command, cancellationToken);
var result = await executorBridge.ExecuteAsync(user, "update_notifications", new
{
action = "mark_read",
notification_id = notificationId
}, confirmationToken: null, cancellationToken);

return result.IsSuccess
? $"Marked notification {notificationId} as read."
: $"Error: {result.Error}";
return result.Succeeded ? $"Marked notification {notificationId} as read." : result.Message;
}

[McpServerTool(Name = "mark_all_notifications_read"), Description("Mark all notifications as read.")]
public async Task<string> MarkAllNotificationsRead(
ClaimsPrincipal user,
CancellationToken cancellationToken = default)
{
var userId = GetUserId(user);
var result = await mediator.Send(new MarkAllNotificationsReadCommand(userId), cancellationToken);
var result = await executorBridge.ExecuteAsync(user, "update_notifications", new
{
action = "mark_all_read"
}, confirmationToken: null, cancellationToken);

return result.IsSuccess
? $"Marked {result.Value} notifications as read."
: $"Error: {result.Error}";
return result.Succeeded ? "Marked all notifications as read." : result.Message;
}

[McpServerTool(Name = "delete_notification"), Description("Delete a specific notification.")]
public async Task<string> DeleteNotification(
ClaimsPrincipal user,
[Description("The notification ID (GUID)")] string notificationId,
[Description("Confirmation token returned by confirm_agent_operation_v2 (required: deleting a notification is destructive)")] string? confirmationToken = null,
CancellationToken cancellationToken = default)
{
var userId = GetUserId(user);
var command = new DeleteNotificationCommand(userId, McpInputParser.ParseGuid(notificationId, "notificationId"));
var result = await mediator.Send(command, cancellationToken);
var result = await executorBridge.ExecuteAsync(user, "delete_notifications", new
{
action = "delete_one",
notification_id = notificationId
}, confirmationToken, cancellationToken);

return result.IsSuccess
? $"Deleted notification {notificationId}."
: $"Error: {result.Error}";
return result.Succeeded ? $"Deleted notification {notificationId}." : result.Message;
}

private static Guid GetUserId(ClaimsPrincipal user)
Expand Down
Loading
Loading