Skip to content

fix: prevent bad habits from showing overdue and auto-advance DueDate - #14

Merged
thomasluizon merged 2 commits into
mainfrom
fix/bad-habit-overdue-and-duedate
Mar 21, 2026
Merged

fix: prevent bad habits from showing overdue and auto-advance DueDate#14
thomasluizon merged 2 commits into
mainfrom
fix/bad-habit-overdue-and-duedate

Conversation

@thomasluizon

Copy link
Copy Markdown
Owner

Summary

  • Bad habits no longer show as overdue when not logged (not logging = good behavior)
  • Stale bad habit DueDates auto-advance on schedule fetch so day-specific scheduling works correctly
  • Add FindTrackedAsync to repository, make AdvanceDueDate public

Test plan

  • Create a daily bad habit, don't log it, verify it doesn't show as overdue the next day
  • Create a bad habit on specific days (e.g. Mon/Wed/Fri), verify DueDate advances correctly

Generated with Claude Code

thomasluizon and others added 2 commits March 21, 2026 16:56
Bypass email verification for a configurable test account so Google Play
reviewers can log in without needing access to a real email inbox.
Controlled by REVIEWER_TEST_EMAIL and REVIEWER_TEST_CODE env vars.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Bad habits should not show as overdue when not logged -- not logging
means the user successfully avoided the bad behavior. Also auto-advance
stale bad habit DueDates on schedule query so habits with specific days
(e.g. Mon/Wed/Fri) correctly show their next occurrence.

- Add !IsBadHabit to all three overdue checks in GetHabitScheduleQuery
- Make AdvanceDueDate public on Habit entity
- Add FindTrackedAsync to IGenericRepository
- Advance stale bad habit DueDates in schedule query handler

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@thomasluizon
thomasluizon merged commit 7ffd6c6 into main Mar 21, 2026
1 check passed
@thomasluizon
thomasluizon deleted the fix/bad-habit-overdue-and-duedate branch March 21, 2026 20:06
thomasluizon added a commit that referenced this pull request Jul 3, 2026
…w rubric

Mirror of the orbit-ui-mobile rubric addition (thomasluizon/orbit-ui-mobile#386):
API diffs that change the user-facing feature surface (gating, Astra/MCP tools)
must flag the required FEATURES.md update in the paired frontend PR.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
thomasluizon added a commit that referenced this pull request Jul 4, 2026
* chore: prune superseded root docs — description.md + mangled planning orphan

Removes two dead root-level docs superseded by README.md; the second is a
path-collapsed junk filename. Docs-only; no code references them.

Refs thomasluizon/orbit-ui-mobile#380

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* chore(review): add FEATURES.md parity dimension (#14) to the pr-review rubric

Mirror of the orbit-ui-mobile rubric addition (thomasluizon/orbit-ui-mobile#386):
API diffs that change the user-facing feature surface (gating, Astra/MCP tools)
must flag the required FEATURES.md update in the paired frontend PR.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

---------

Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant