deps: pin node's major, and fix the reasoning in the Dockerfile comment - #104
Merged
Merged
Conversation
Dependabot's first run under the new grouping offered node 24-slim -> 26-slim. CI passed -- npm's engines check is only a warning, and only the Dockerfile moved -- but taking it would ship an image built on node 26 while ci.yml and the devcontainer still test on 24, re-introducing exactly the drift #92 removed. It is also outside the engines range the project declares, and node 26 is still Current rather than LTS. node's major is therefore pinned, matching the typescript rule: it moves deliberately with an Angular upgrade, across all four references at once. Digest and minor updates keep flowing. The Dockerfile comment claimed odd-numbered majors were what gets skipped; 26 is even, so that was wrong. The real gate is the engines range plus LTS status.
thomas-lg
added a commit
that referenced
this pull request
Sep 13, 2026
…nt (#104) Dependabot's first run under the new grouping offered node 24-slim -> 26-slim. CI passed -- npm's engines check is only a warning, and only the Dockerfile moved -- but taking it would ship an image built on node 26 while ci.yml and the devcontainer still test on 24, re-introducing exactly the drift #92 removed. It is also outside the engines range the project declares, and node 26 is still Current rather than LTS. node's major is therefore pinned, matching the typescript rule: it moves deliberately with an Angular upgrade, across all four references at once. Digest and minor updates keep flowing. The Dockerfile comment claimed odd-numbered majors were what gets skipped; 26 is even, so that was wrong. The real gate is the engines range plus LTS status.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dependabot's first run under the new grouping (#102) immediately offered node 24-slim → 26-slim (#103). Useful test of the config — and a case worth encoding as a rule.
Why #103 was closed despite being green
CI passed, but that's misleading: npm's
enginescheck is only a warning, and only the Dockerfile would have moved.ci.ymlrunsnode-version: 24and the devcontainer's node feature is24. Merging it would ship a production image built on node 26 while everything that tests the code runs 24 — precisely the three-way drift #92 existed to remove.Two further reasons:
"node": "^20.19.0 || ^22.12.0 || ^24.0.0"— Angular's supported range.What this changes
dependabot.yml— ignorenodeatsemver-majorin the docker ecosystem, matching thetypescriptrule. Both are pinned by Angular, so both should move deliberately with an Angular upgrade rather than weekly on their own. Digest and minor updates keep flowing.Dockerfile— correct the comment. It said odd-numbered (non-LTS) majors are "deliberately skipped", but 26 is even, so that reasoning was incomplete and would have misled the next reader. The actual gate is the engines range plus LTS status.Config verified end to end
#102 triggered a real Dependabot re-evaluation, which is what turned up #103. Observed from that run:
Merging this triggers one more re-evaluation, after which node majors should stop appearing too.