Merge pull request #107 from ahwayakchih/fix-loading-relative-path

fix: loading relative path
thom4parisot · Apr 17, 2019 · 4135ebf · 4135ebf
2 parents afbc5d4 + c0b10da
commit 4135ebf
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 2 deletions.
diff --git a/src/resolver.js b/src/resolver.js
@@ -7,7 +7,7 @@ module.exports = function resolve(pathOrFiles) {
     // legacy and original mode
     if (typeof pathOrFiles === "string") {
       return resolve({
-        path: pathOrFiles,
+        path: path.resolve(pathOrFiles),
         src: "**"
       });
     }

diff --git a/test/index.js b/test/index.js
@@ -31,10 +31,21 @@ TESTS.ChromeExtension = function(t, opts){
 
 
 TESTS.load = function(t, opts){
-  t.plan(4);
+  t.plan(6);
 
   newCrx(opts).load().then(t.pass);
 
+  // Test relative path
+  newCrx().load("./test/myFirstExtension").then(function(crx){
+    t.ok(crx);
+  }).catch(t.error.bind(t));
+
+  // Test absolute path
+  newCrx().load(join(__dirname, "myFirstExtension")).then(function(crx){
+    t.ok(crx);
+  }).catch(t.error.bind(t));
+
+  // Test list of files
   var fileList = [
     'test/myFirstExtension/manifest.json',
     'test/myFirstExtension/icon.png',