Remove adjoint method calling transpose #383
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 18, 2021
fingolfin
force-pushed
the
mh/remove-adjoint
branch
from
9908012 to
8c8ff53
Compare
In Julia, adjoint is conjugate transposition these days
fingolfin
force-pushed
the
mh/remove-adjoint
branch
from
8c8ff53 to
54e76d6
Compare
Codecov Report
@@ Coverage Diff @@
## master #383 +/- ##
==========================================
- Coverage 66.24% 66.24% -0.01%
==========================================
Files 295 295
Lines 89049 89048 -1
==========================================
- Hits 58993 58989 -4
- Misses 30056 30059 +3
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR supersedes PR #234 ; I wanted to use a branch which has a name matching that of its sibling PRs, Nemocas/AbstractAlgebra.jl#838 and Nemocas/Nemo.jl#1162, so that the CI code for testing against branches with matching names has a chance of kicking in.
(I don't know if it actually does because back when it was written, I think it only searched for matching branches on the same repo, not for matching branches in other repos. Since I have no push access to any of the involved repositories... anyway, @benlorenz or @thofma will know)