Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor fixes for type stability #1189

Merged
merged 1 commit into from
Aug 17, 2023
Merged

Minor fixes for type stability #1189

merged 1 commit into from
Aug 17, 2023

Conversation

thofma
Copy link
Owner

@thofma thofma commented Aug 15, 2023

No description provided.

@StevellM
Copy link
Collaborator

Is there a specific reason to change all the @assert all(-bla-) into loops of assertions ?

@thofma
Copy link
Owner Author

thofma commented Aug 16, 2023

Type stability (JuliaLang/julia#15276). There might be a different way to do which is less intrusive. I will explore it a bit more.

@codecov
Copy link

codecov bot commented Aug 16, 2023

Codecov Report

Patch coverage: 95.23% and project coverage change: -0.05% ⚠️

Comparison is base (dbb4f5a) 74.42% compared to head (2920683) 74.38%.
Report is 1 commits behind head on master.

❗ Current head 2920683 differs from pull request most recent head abf062f. Consider uploading reports for the commit abf062f to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1189      +/-   ##
==========================================
- Coverage   74.42%   74.38%   -0.05%     
==========================================
  Files         346      346              
  Lines      110725   110719       -6     
==========================================
- Hits        82411    82353      -58     
- Misses      28314    28366      +52     
Files Changed Coverage Δ
src/QuadForm/QuadBin.jl 85.41% <66.66%> (-0.17%) ⬇️
src/QuadForm/Quad/GenusRep.jl 87.77% <100.00%> (+0.05%) ⬆️
src/QuadForm/Quad/ZGenus.jl 94.25% <100.00%> (ø)

... and 25 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@thofma thofma merged commit 61a5f43 into master Aug 17, 2023
14 of 17 checks passed
@thofma thofma deleted the th/types branch August 17, 2023 11:45
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants