Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the conflict between paths for OutputPath & ArchiveFileName #65

Conversation

iRebbok
Copy link
Contributor

@iRebbok iRebbok commented Jul 22, 2020

@kborowinski mentioned in #63 a conflict between absolute paths in ArchiveFileName, now this is fixed, and also with relative paths.

Compress-7Zip -Path C:\TestFolder -ArchiveFileName C:\TMP\Test.7z

will create an archive in C:\TMP.

Compress-7Zip -Path C:\TestFolder -ArchiveFileName ..\Test.7z

will create an archive in the parent folder of the current folder.

Compress-7Zip -Path C:\TestFolder -ArchiveFileName C:\TMP\Test.7z -OutputPath C:\MyPath

will create an archive in C:\MyPath.

I think this is what completely resolves the conflict between ArchiveFileName & OutputPath.

@iRebbok iRebbok force-pushed the fix/conflict_with_outputpath_and_archivefilename branch from 8717ebd to d660e31 Compare July 22, 2020 07:20
@thoemmi
Copy link
Owner

thoemmi commented Jul 22, 2020

Looks good to me. @kborowinski, what do you think?

@thoemmi thoemmi added the bug label Jul 22, 2020
@kborowinski
Copy link
Contributor

@thoemmi @iRebbok Looks good to me.

@thoemmi thoemmi merged commit a7c2fe2 into thoemmi:master Jul 22, 2020
@thoemmi
Copy link
Owner

thoemmi commented Jul 22, 2020

Version 1.13 has been published to PowerShell Gallery. Thanks for your work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants