Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update type definitions to reflect new Definitely Typed updates #88

Closed
wants to merge 1 commit into from
Closed

Update type definitions to reflect new Definitely Typed updates #88

wants to merge 1 commit into from

Conversation

securingsincity
Copy link

No description provided.

@thlorenz
Copy link
Owner

thlorenz commented Jun 3, 2017

Did you run the update scripts?
Wanna make sure the definitions aren't out of sync with the current version we are based on.

@securingsincity
Copy link
Author

I tried running the update scripts but they were failing. I made the change in the DefinitelyTyped Repo so in this case they match. I'll try to run the script again and see if I missed something.

@securingsincity
Copy link
Author

Just to follow up, looks like all of the types in DefinitelyTyped moved to a types directory rather than the root which the update-ts script was looking for. I can try fixing the script.

@securingsincity securingsincity mentioned this pull request Jun 3, 2017
Closed
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@securingsincity @thlorenz