-
-
Notifications
You must be signed in to change notification settings - Fork 302
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Brace 0.11.2 (bumps ace to 1.4.2; adds travis support) #152
Conversation
I would definitely love to see brace updated to the latest ace, it's tough to diagnose issues when the underlying dep is so far behind. react-ace is also suffering as a result and it'd be a lot easier (in theory) to fix their problem here than having them move off brace. |
I pinged him on Twitter and he said he'd see to this mid-January So I think this might be coming soon? |
@thlorenz Hey buddy, could you please hit merge? |
Hey looks good @StoneCypher , but I'd prefer two things:
So ideally this PR would have ONE commit which bumps the version in the update script and includes the result of running it (changed Ace files). |
i don't understand what you mean by "bumps the version in the update script" |
I mean please don't change the brace version inside the package.json as I take care of that during the publish step to npm. |
I have removed the I believe that's what I'm supposed to do, but I have a bad flu and I'm stupid when I'm sick |
I will reintegrate travis in a followup PR if you say this is what you meant |
OK, could you please squash all this into one commit? At this point there are tons of commits here including a merge of another PR which I'm not sure about why it is even here. |
Oh. Okay |
ahaaaa haaaaaaaaaaaa downloading large repos on conference wifi |
This PR: