Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update worker patch to work with ace 1.9 #109

Closed
wants to merge 3 commits into from

Conversation

nightwing
Copy link
Contributor

this is based on #93

I've only added the last commit 7e33fe7 which updates the worker patch for the new version of ace, and adds an early for the case when not all lines to replace are found.

@thlorenz
Copy link
Owner

@nightwing nice, did you make sure the tests still pass?

@nightwing
Copy link
Contributor Author

yes, i get

TAP version 13
# error annotations provided by inlined worker
ok 1 javascript editor shows one error
ok 2 on line 5
ok 3 coffee editor shows one error
ok 4 on line 5
ok 5 json editor shows one error
ok 6 on line 5
ok 7 lua editor shows one error
ok 8 on line 6
ok 9 xml editor shows one error
ok 10 on line 5

1..10
# tests 10
# pass  10

# ok

un browser console

@thlorenz
Copy link
Owner

Thanks, merged and published as v0.11.0

@thlorenz thlorenz closed this Nov 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants