Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, when actkbd is daemonized, the noclose argument is given as zero in order to prevent logging to stdout and stderr in the style of traditional non-interactive daemons.
For many people using systemd, a service unit might contain something like this:
where logs to stdout/stderr should normally show up via
journalctl -u actkbd
.However, since logging is turned off by the
--daemon
flag, this causes a huge amount of confusion when the environment from whichactkbd
is being executed lacks the correct permissions / environment variables for the commands you are running.Additional motivating points:
--daemon
and instead create a systemd unit ofType=simple
. However, this seems to have its own downsides.-l
segfaults, leading the average jane/joe down the peculiar unixy rabbit hole that is "What is this thing X and why does it break my system?".--quiet
). Keeping the logs should be equally simple and, I'd argue, the correct default for most people.