Skip to content

fix: Single/Plural words #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Zelig880 merged 3 commits into from
Oct 22, 2024
Merged

fix: Single/Plural words #21

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
aaefafa
fix: Single/Plural words
markshenouda Oct 21, 2024
2046d05
fix: lans count
markshenouda Oct 21, 2024
5704198
fix: add ? to not trigger a JS error
markshenouda Oct 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/components/CCIP/Cards/NetworkCard.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ function NetworkCard({ name, totalLanes, totalTokens, logo }: NetworkCardProps)
<div>
<h3>{name}</h3>
<p>
{totalLanes} lanes | {totalTokens} tokens
{totalLanes} {totalLanes > 1 ? "lanes" : "lane"} | {totalTokens} {totalTokens > 1 ? "tokens" : "token"}
</p>
</div>
</div>
Expand Down
14 changes: 11 additions & 3 deletions src/components/CCIP/Search/Search.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,7 +115,8 @@ function Search({ chains, tokens, small, environment, lanes }: SearchProps) {
{network.name}
{!small && (
<span>
{network.totalLanes} lanes | {network.totalTokens} tokens
{network.totalLanes} {network.totalLanes > 1 ? "lanes" : "lane"} | {network.totalTokens}{" "}
{network.totalTokens > 1 ? "tokens" : "token"}
</span>
)}
</a>
Expand All @@ -133,7 +134,11 @@ function Search({ chains, tokens, small, environment, lanes }: SearchProps) {
<a href={`/ccip/supported-networks/${environment}/token/${token.name}`}>
<img src={token.logo} alt="" />
{token.name}
{!small && <span>{token.totalNetworks} networks</span>}
{!small && (
<span>
{token.totalNetworks} {token.totalNetworks > 1 ? "networks" : "network"}
</span>
)}
</a>
</li>
))}
Expand Down Expand Up @@ -171,7 +176,10 @@ function Search({ chains, tokens, small, environment, lanes }: SearchProps) {
{lane.sourceNetwork.name} {">"} {lane.destinationNetwork.name}
{!small && (
<span>
{lane?.lane?.supportedTokens ? Object.keys(lane.lane.supportedTokens).length : 0} tokens
{lane?.lane?.supportedTokens ? Object.keys(lane.lane.supportedTokens).length : 0}{" "}
{lane.lane.supportedTokens && Object.keys(lane.lane.supportedTokens).length > 1

@Zelig880 Zelig880 Oct 22, 2024

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to add the ? here, otherwise it will trigger a JS error if missing

@markshenouda markshenouda Oct 22, 2024

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah it's in the next line 181

@Zelig880 Zelig880 Oct 22, 2024

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I meant this lane.lane.supportedTokens should be changed with lane?.lane?.supportedTokens

? "tokens"
: "token"}
</span>
)}
</a>
Expand Down