Bump target to iOS7, introduce nullability, always async, and separate storage from queue #22

gelosi · 2016-02-19T15:30:33Z

Hi! Have a look please

I've updated README accordingly. Idea is:

introduce QueueJob to avoid direct using NSDictinary for creating jobs (plan to add to Job max retry times, expiration date, fire date, etc)
introduce nullability to prepare for Swift migration
decoupling storage from queue using EDQueuePersistentStorage brotocoli :)
adding some basic tests on top of that (to be continued)

added nullability added EDQueueJob instead of dictionary + keys (for user data it still provides userInfo dictionary, nullable)

Updated Code & Example Added basic Queue tests README updated accordingly

thisandagain · 2016-02-19T17:17:48Z

Very cool. Taking a look now.

thisandagain · 2016-02-19T17:18:14Z

EDQueue.podspec

-  s.authors      = {'Andrew Sliwinski' => '[email protected]', 'Francois Lambert' => '[email protected]'}
-  s.source       = { :git => 'https://github.com/thisandagain/queue.git', :tag => 'v0.7.1' }
-  s.platform     = :ios, '5.0'
+  s.homepage     = 'https://github.com/gelosi/queue'


Why would we move the location of the homepage and repo?

I've set it to mine now to use it already, but if you will accept the changes in the end (I'm still on it) I'd be happy to keep original link to repo.

thisandagain · 2016-02-19T18:04:08Z

Overall this is great. Thanks for pulling this together @gelosi . I left you a few comments and notes for discussion.

gelosi · 2016-02-19T18:13:54Z

Hi Andrew

Cool! Thank you for a quick feedback. This is a very start. I will try to offer some idea on 'built-in' persistent storage. As I suppose apps which using already some sqlite wrapper different from FMDB might stay aside. That is my approach. Ideally - having ready-to go fmdb submodule (as default dependency). And reduce persistent storage interface requirements to CRUD :)

—
RO

On Fri, Feb 19, 2016 at 7:04 PM, Andrew Sliwinski
[email protected] wrote:

Overall this is great. Thanks for pulling this together @gelosi . I left you a few comments and notes for discussion.

Reply to this email directly or view it on GitHub:
#22 (comment)

…of EDQueueJob; introduced EDQueueStoredJob protocol (to be renamed)

gelosi · 2016-02-24T00:30:41Z

@thisandagain so, shaping better approach. Have a look, please.

…ueue lost retryCount respectively; More Tests!

…etchNextJobTimeInterval`). Also, fixed critical bug - a race condition in queue. So, job might be executed two times :/ Hola TDD!

nikolaykasyanov · 2016-03-01T14:25:09Z

EDQueue/EDQueueJob.h

+@end
+
+
+NS_ASSUME_NONNULL_END


New line missing

nikolaykasyanov · 2016-03-01T14:26:50Z

EDQueue/EDQueuePersistentStorageProtocol.h

+@property(nonatomic, readonly) EDQueueJob *job;
+
+@property(nonatomic, readonly, nullable) NSNumber *jobID;
+@property(nonatomic, readonly, nullable) NSNumber *attempts;


Let's just use @0 as a default value and avoid nil.

…will get it's own :)

…EDQueueStorageItem protocol (and EDQueueStorageEngineJob respectively), blocked +new method from EDQueueJob ^^,

…r NSCoded objects)

gelosi added 3 commits February 18, 2016 17:09

🍋 sanitise code

6f779a5

upgraded project to the more-less modern state (iOS 7 bottomline)

9d08d34

added nullability added EDQueueJob instead of dictionary + keys (for user data it still provides userInfo dictionary, nullable)

Introduced Persistent Storage Injection for Queue

9adb89e

Updated Code & Example Added basic Queue tests README updated accordingly

gelosi force-pushed the master branch from 49a1005 to 9adb89e Compare February 19, 2016 16:28

added NSDictionary contents enforcements

63a2f12

thisandagain added the pr - needs review label Feb 19, 2016

thisandagain self-assigned this Feb 19, 2016

thisandagain reviewed Feb 19, 2016
View reviewed changes

thisandagain added pr - needs work and removed pr - needs review labels Feb 19, 2016

thisandagain added the needs discussion label Feb 19, 2016

gelosi added 4 commits February 23, 2016 17:01

Refactoring part one: removing unnecessary for public use properties …

9673f1a

…of EDQueueJob; introduced EDQueueStoredJob protocol (to be renamed)

Renamed EDQueueStoredJob to EDQueueStorageItem which is way more logical

1f2c92a

Refeactor stage two: code Task becomes Tag

bd34c48

Refactoring: tune things up in line with merge request thisandagain#22

068d114

gelosi added 3 commits February 24, 2016 17:27

EDQueueJob got expiration date, maxRetryCount, retryTimeInterval; EDQ…

474a202

…ueue lost retryCount respectively; More Tests!

Removes expired jobs along with removing job by ID

82a64aa

Queue got jobCount & better scheduling though storage requirement (`f…

12e0b86

…etchNextJobTimeInterval`). Also, fixed critical bug - a race condition in queue. So, job might be executed two times :/ Hola TDD!

nikolaykasyanov reviewed Mar 1, 2016
View reviewed changes

EDQueue/EDQueueJob.h

@end

NS_ASSUME_NONNULL_END

Copy link

nikolaykasyanov Mar 1, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New line missing

nikolaykasyanov reviewed Mar 1, 2016
View reviewed changes

gelosi added 3 commits March 1, 2016 17:23

fixed issue with global dispatch queue (so, each instance if EDQueue …

22aac2c

…will get it's own :)

Interface refactoring: removed nullability from attempts property of …

29f231c

…EDQueueStorageItem protocol (and EDQueueStorageEngineJob respectively), blocked +new method from EDQueueJob ^^,

StorageEngine: use more powerful NSKeyedArchiver (allows to store you…

7e25335

…r NSCoded objects)

gelosi force-pushed the master branch from 6c144cb to 7e25335 Compare July 6, 2016 12:28

thisandagain removed the needs discussion label Feb 9, 2017

thisandagain removed their assignment Mar 21, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Bump target to iOS7, introduce nullability, always async, and separate storage from queue #22

Bump target to iOS7, introduce nullability, always async, and separate storage from queue #22

gelosi commented Feb 19, 2016

thisandagain commented Feb 19, 2016

thisandagain Feb 19, 2016

gelosi Feb 23, 2016

thisandagain commented Feb 19, 2016

gelosi commented Feb 19, 2016

Overall this is great. Thanks for pulling this together @gelosi . I left you a few comments and notes for discussion.

gelosi commented Feb 24, 2016

nikolaykasyanov Mar 1, 2016

nikolaykasyanov Mar 1, 2016

gelosi Mar 7, 2016

Bump target to iOS7, introduce nullability, always async, and separate storage from queue #22

Are you sure you want to change the base?

Bump target to iOS7, introduce nullability, always async, and separate storage from queue #22

Conversation

gelosi commented Feb 19, 2016

thisandagain commented Feb 19, 2016

thisandagain Feb 19, 2016

Choose a reason for hiding this comment

gelosi Feb 23, 2016

Choose a reason for hiding this comment

thisandagain commented Feb 19, 2016

gelosi commented Feb 19, 2016

Overall this is great. Thanks for pulling this together @gelosi . I left you a few comments and notes for discussion.

gelosi commented Feb 24, 2016

nikolaykasyanov Mar 1, 2016

Choose a reason for hiding this comment

nikolaykasyanov Mar 1, 2016

Choose a reason for hiding this comment

gelosi Mar 7, 2016

Choose a reason for hiding this comment