Review ANSI row IR follow-up fixes - #3
Open
thirtiseven wants to merge 6 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This is a review-only stacked PR on top of
codex-ansi-jit-on-current.It collects local follow-up changes found while validating ANSI row IR support from NVIDIA#22224 with spark-rapids:
IF_ELSEimplementation issuesNotes
This PR is not intended to include the upstream/main merge diff. The base branch already contains that context, so the review diff should only show the follow-up commits in this branch.
Some items here may be better split or discussed upstream before merging, especially where Spark semantics and cuDF operator semantics differ.
Testing
Not run in this PR creation step.