-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Friday, December 13, 2024 Deployment #137
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…l-publisher-links Update shouldAvoidUnpaywall to avoid publisher links
informational note sections
…late Update PR template to include deploy prerequisite and deploy...
…late Add missing word
We'll only look at that after the Unpaywall call is made
… does not result in enhancing a search result for Primo or Summon
…n Third Iron API says avoidUnpaywallPublisherLinks
No tests yet, just adding the functionality
Added basically the same scenarios as EOCs have, but with problematic journal data instead
…host_type-logic Ignore Unpaywall response when article has "avoidUnpaywallPublisherLinks" set to true and host_type is "publisher" - bz 8727
thirdiron-circleci
changed the title
Wednesday, September 4, 2024 Deployment
Tuesday, December 3, 2024 Deployment
Dec 3, 2024
If there is no retraction URL or EOC notice URL, but there is a problematic journal notice URL, we should show the problematic journal link. There is no Discovery Service Adapter configuration to control this particular feature - it's either turn it on or off everywhere for a library.
…c-journals Add problematic journal support - bz 7970
karlbecker
changed the title
Tuesday, December 3, 2024 Deployment
Friday, December 13, 2024 Deployment
Dec 13, 2024
karlbecker
approved these changes
Dec 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
I checked the two QA boxes here @JMalone29 , confirmed that's fine (BZ-8744 was moved to shipped awhile ago, it's a non-functional change, it just updated the release notes generator stuff). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release Notes - See All Jiras
Deploy Prerequisites
Deploy Precautions
Deploy Information Notes
Pre-Deploy Checklist
Post-Deploy Checklist
@JMalone29 @kcarlson87