Improve token refresh and add token login method #51
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Rename `self.token_info.refreshToken` to `exp` - Stop storing the username/password - Store the `refreshToken` from the login request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#22 fixes the token refreshing not working at all, but it still uses the stored
usernameandpasswordto work. This PR stores therefreshTokenon the first login and uses it on theapi/auth/tokenroute to login without credentials.Also,
refreshTokenexpires 7 days after being issued, and gets refreshed with the actual token, so there's no way it'll expire in between refreshes.Besides that I also added a
token_loginmethod to reuse an user providedtoken/refreshToken. I'm creating an app that performs actions on TB as the app user and this would allow me to only use their tokens instead of storing their credentials.