-
Notifications
You must be signed in to change notification settings - Fork 0
45/unit formatter not reponding to pref change #46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
DanCouper
wants to merge
18
commits into
develop
Choose a base branch
from
45/unit_formatter_not_reponding_to_pref_change
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
45/unit formatter not reponding to pref change #46
DanCouper
wants to merge
18
commits into
develop
from
45/unit_formatter_not_reponding_to_pref_change
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- unit-formatters becomes data-transformers.
- remove provider, just use a hook, API otherwise identical
- user-preferences becomes application-conguration
- provider is now ApplicationConfigProvider, usePrefs hook becomes usePreferences, add useConfig hook
- shared-types now redundant, move types into application-configuration which can now be set as a peer dependency of everything else.
- update user-preferences-store-{web|native} to use new application-configuration package
…terface, update playground to test
…ases for new packages
- application-configuration (1.0) - data-transformers (1.0) - user-preferences-store-native (1.0) - user-preferences-store-web (1.0)
…hange - fixed merge conflicts - updated package versions to latest - newer versions of XState expose ContextFrom and EventFrom types, rather than [the previously slightly experimental] ModelContextFrom and ModelEventsFrom so replace instances of these throughout auth lib.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #45
BREAKING CHANGES
@thingco/user-preferencesbecomes@thingco/application-configurationApplicationConfigProvider,usePrefshook becomesusePreferences, adduseConfighook.@thingco/shared-typesnow redundant, moved types into@thingco/application-configuration(which can now be set as a peer dependency of everything else).@thingco/user-preferences-store-{web|native}to use new@thingco/application-configurationpackage.@thingco/unit-formattersbecomes@thingco/data-transformers.