-
Notifications
You must be signed in to change notification settings - Fork 0
26/component library refinements #27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
DanCouper
wants to merge
14
commits into
develop
Choose a base branch
from
26/component_library_refinements
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ound NOTES: - no tooltips yet - definitely need to sort out the annotations
- switch Yarn to use node-modules for now to allow Node to use ESModules. NOTE I don't really want to do this, but it'll all work the same, and can bring PnP back in once ESModule support is finalised. - add zx as a dependency - write a script to create new packages - create @thingco/component-lib-v2 package
…citonal native playground
…cluding icon generation - set up Stitches - added a type scale to generate font/general sizings - filled in basics of the theme - added a few basic components (Text, mainly) - added a very primitive design tool to aid in producing the lib - added all this to playground - ported Polymorphic component type from radix-ui in preparation for building out components - zx scripting added to generate line icons - initial checks on sanity of generated code done
- script to build icons now functions, and generates code that works - it accepts a directory of files and builds a file called LineIcons.tsx - this typechecks - NOTE to allow it to typecheck, have had to set skipLibCheck to true in the component lib tsconfig, will open issue on stitches for it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a big job, but it can't really be PRed in bits, it needs a pretty much fully-functional result to be usefully reviewed.
Tasks
@thingco/component-library-v2and@thingco/component-library-native-v2Links
(here so I can reference them easily rather than having them in a few of the million and one tabs I have open)
TS/React stuff
SVG Stuff -- this is a painful workflow but it'll do to get the icons functional:
Material Design -- not the prettiest thing ever but need the thinking behind it
Other systems
Various articles
Various stuff
Useful resources