Skip to content

Conversation

@reubenmiller
Copy link
Contributor

@reubenmiller reubenmiller commented Nov 25, 2025

Proposed changes

Update Rust dependences (crates) to the latest version which required some code additional code changes due to breaking changes being introduced.

The following details the reason why some of the remaining dependencies that can't/won't be updated in this PR.

Update in separate PR

nix

Upgrading nix will require more changes which are best done in a separate PR. #3879 has been created to track the upgrade.

dependency current upgrade
nix 0.26.4 0.30.1

Unable to update

The following dependencies are not able to be currently updated for the following reasons.

rasn - currently uses unstable Rust api in Rust 1.85

The newer versions of rasn uses unsigned_is_multiple_of which is still marked as unstable in the current MSRV (1.85). This means that the crates can't be updated until the MSRV is bumped to Rust 1.87 where the language feature was stabilized.

dependency current upgrade
rasn 0.26.6 0.28.1
rasn-cms 0.26.6 0.28.1

async-tungstenite

There is a version dependency between ws_stream_tungstenite and async-tungstenite which is preventing upgrading async-tungstenite to the latest available version.

dependency current upgrade
async-tungstenite 0.29.1 0.32.0

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Improvement (general improvements like code refactoring that doesn't explicitly fix a bug or add any new functionality)
  • Documentation Update (if none of the other choices apply)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Paste Link to the issue


Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA (in all commits with git commit -s. You can activate automatic signing by running just prepare-dev once)
  • I ran just format as mentioned in CODING_GUIDELINES
  • I used just check as mentioned in CODING_GUIDELINES
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

@reubenmiller reubenmiller added the dependencies Pull requests that update a dependency file label Nov 25, 2025
@codecov
Copy link

codecov bot commented Nov 25, 2025

Codecov Report

❌ Patch coverage is 0% with 14 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
crates/core/tedge_watchdog/src/systemd_watchdog.rs 0.00% 11 Missing ⚠️
crates/common/tedge_utils/src/notify.rs 0.00% 0 Missing and 1 partial ⚠️
...tes/core/tedge/src/cli/certificate/c8y/download.rs 0.00% 1 Missing ⚠️
...rates/core/tedge/src/cli/certificate/c8y/upload.rs 0.00% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 25, 2025

Robot Results

✅ Passed ❌ Failed ⏭️ Skipped Total Pass % ⏱️ Duration
743 0 3 743 100 2h22m12.203265999s

Copy link
Contributor

@didier-wenzek didier-wenzek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@reubenmiller reubenmiller added this pull request to the merge queue Nov 26, 2025
Merged via the queue into thin-edge:main with commit 5cb6df5 Nov 26, 2025
51 of 52 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants