-
Notifications
You must be signed in to change notification settings - Fork 70
chore: update Rust dependencies and refactor code #3878
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
reubenmiller
merged 4 commits into
thin-edge:main
from
reubenmiller:chore-update-crates-2025-11-26-2
Nov 26, 2025
Merged
chore: update Rust dependencies and refactor code #3878
reubenmiller
merged 4 commits into
thin-edge:main
from
reubenmiller:chore-update-crates-2025-11-26-2
Nov 26, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! 🚀 New features to boost your workflow:
|
Contributor
Robot Results
|
Signed-off-by: reubenmiller <[email protected]>
Signed-off-by: reubenmiller <[email protected]>
Signed-off-by: reubenmiller <[email protected]>
Signed-off-by: reubenmiller <[email protected]>
950d9bf to
4a62cd4
Compare
albinsuresh
approved these changes
Nov 26, 2025
didier-wenzek
approved these changes
Nov 26, 2025
Contributor
didier-wenzek
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Update Rust dependences (crates) to the latest version which required some code additional code changes due to breaking changes being introduced.
The following details the reason why some of the remaining dependencies that can't/won't be updated in this PR.
Update in separate PR
nix
Upgrading
nixwill require more changes which are best done in a separate PR. #3879 has been created to track the upgrade.Unable to update
The following dependencies are not able to be currently updated for the following reasons.
rasn - currently uses unstable Rust api in Rust 1.85
The newer versions of rasn uses
unsigned_is_multiple_ofwhich is still marked as unstable in the current MSRV (1.85). This means that the crates can't be updated until the MSRV is bumped to Rust 1.87 where the language feature was stabilized.async-tungstenite
There is a version dependency between
ws_stream_tungsteniteandasync-tungstenitewhich is preventing upgradingasync-tungsteniteto the latest available version.Types of changes
Paste Link to the issue
Checklist
just prepare-devonce)just formatas mentioned in CODING_GUIDELINESjust checkas mentioned in CODING_GUIDELINESFurther comments