Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: avoid using 444 permissions in example tedge-configuration file #2948

Merged

Conversation

reubenmiller
Copy link
Contributor

Proposed changes

Use linux permissions 644 instead of 444 as the latter is unexpected for most users as it does not allow users to edit the file, and give that it is the tedge-log-plugin file, then it should be editable for the owner.

This change was initiated after a customer interaction.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Improvement (general improvements like code refactoring that doesn't explicitly fix a bug or add any new functionality)
  • Documentation Update (if none of the other choices apply)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Paste Link to the issue


Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA (in all commits with git commit -s)
  • I ran cargo fmt as mentioned in CODING_GUIDELINES
  • I used cargo clippy as mentioned in CODING_GUIDELINES
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

Copy link
Contributor

@didier-wenzek didier-wenzek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

Copy link

codecov bot commented Jun 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.2%. Comparing base (23c2714) to head (5826ae2).
Report is 10 commits behind head on main.

Additional details and impacted files
Files Coverage Δ
crates/extensions/tedge_config_manager/src/lib.rs 59.4% <100.0%> (ø)
...rates/extensions/tedge_config_manager/src/tests.rs 91.7% <100.0%> (ø)

... and 11 files with indirect coverage changes

Copy link
Contributor

Robot Results

✅ Passed ❌ Failed ⏭️ Skipped Total Pass % ⏱️ Duration
453 0 3 453 100 1h10m50.886882s

@reubenmiller reubenmiller added this pull request to the merge queue Jun 18, 2024
Merged via the queue into thin-edge:main with commit 8502b28 Jun 18, 2024
33 checks passed
@reubenmiller reubenmiller deleted the feat-avoid-read-only-config-example branch July 18, 2024 13:36
@reubenmiller reubenmiller added the theme:configuration Theme: Configuration management label Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
theme:configuration Theme: Configuration management
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants