Fixing the "This competition's results are visible but not posted" #9706
Conversation
config/locales/en.yml
Outdated
| @@ -1339,6 +1339,7 @@ en: | |||
| uncancel_success: "Successfully uncancelled competition!" | |||
| uncancel_failure: "Cannot uncancel the competition." | |||
| results_not_posted: "This competition's results are visible but haven't been posted yet." | |||
| results_not_posted_non_admins: "We are busy processing this competition's results - they should be available shortly." | |||
There was a problem hiding this comment.
I would rather name the key as something like results_processing or something better. results_processing also looks bit bad to me, but maybe other can suggest better name.
There was a problem hiding this comment.
@gregorbg do you have any suggestions for the key name?
There was a problem hiding this comment.
I suggest results_still_processing
There was a problem hiding this comment.
Gregor's plate is pretty full, hopefully he's fine for Daniel and I to resolve this :D
app/models/competition.rb
Outdated
| @@ -469,7 +469,11 @@ def warnings_for(user) | |||
| end | |||
|
|
|||
| if self.results.any? && !self.results_posted? | |||
| warnings[:results] = I18n.t('competitions.messages.results_not_posted') | |||
| if user.can_admin_results? | |||
There was a problem hiding this comment.
cursory look suggests that this should work, although it's causing a test to fail. I can try debug it in the next day or so
There was a problem hiding this comment.
LGTM
@danieljames-dj would you be able to review/approve as well? I think it's straightforward enough to merge without Gregor's approval, but would appreciate a second set of eyes
This pr should solve #9229 , hopefully.
@danieljames-dj @dunkOnIT this might have errors so please review it :)